Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423889

Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks

From Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks
Date 2016-06-16 12:10 +0200
Message-ID <rKCpj-72x-1@gated-at.bofh.it> (permalink)
References <rKjZn-3Eh-5@gated-at.bofh.it> <rKjZo-3Eh-43@gated-at.bofh.it> <rKCfE-6K5-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof/Javier,
Thanks for review of the series.

I will post the V2 after taking care of all comment.

One query about the comment.

Thanks,
Laxman

On Thursday 16 June 2016 03:24 PM, Krzysztof Kozlowski wrote:
> On 06/15/2016 04:13 PM, Laxman Dewangan wrote:
>>   enum chip_name {
>>   	CHIP_MAX77686,
>>   	CHIP_MAX77802,
>> +	CHIP_MAX77620,
> Now it is more obvious why it is here. However I don't like the
> duplication of device IDs, under different names and different values:
> 1. include/linux/mfd/max77686-private.h
> 2. include/linux/mfd/max77620.h
> 3. here
>
> I was thinking about way of combining it... but these headers are
> different. Unless there will be one header for all three devices.
>
> Anyway, please add the max77686 prefix to the enum.

so will it be:

enum max77686_chip_name {
     CHIP_MAX77686,
     CHIP_MAX77802,
     CHIP_MAX77620,
};


Will it be fine here?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
  [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:20 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver kbuild test robot <lkp@intel.com> - 2016-06-15 17:40 +0200
    [PATCH] clk: max77686: fix semicolon.cocci warnings kbuild test robot <lkp@intel.com> - 2016-06-15 17:40 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:40 +0200
    Re: [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802  driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 15:10 +0200
  [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 3/5] clk: max77686: Add DT binding details for PMIC  MAX77620 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:30 +0200
    Re: [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:50 +0200
  [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:40 +0200
      Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 14:30 +0200
        Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-16 15:10 +0200
          Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-16 15:30 +0200
  [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:20 +0200
      Re: [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:40 +0200
    Re: [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 11:50 +0200
  [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-15 16:30 +0200
    Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-15 17:30 +0200
    Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 12:00 +0200
      Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-16 12:10 +0200
        Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 12:20 +0200
    Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-16 15:10 +0200

csiph-web