Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423014
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 |
| Date | 2016-06-15 15:30 +0200 |
| Message-ID | <rKj3j-34D-15@gated-at.bofh.it> (permalink) |
| References | <rIDIR-3tH-13@gated-at.bofh.it> <rJz0t-69B-17@gated-at.bofh.it> <rK1zs-bN-31@gated-at.bofh.it> <rKd7A-7Q2-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 15, 2016 at 09:09:13AM +0200, Jiri Kosina wrote: > On Tue, 14 Jun 2016, Wim Osterholt wrote: > > > Surprising or not, the thusly compiled kernel ran fine and I could > > handle floppies like before! (open(/dev/fd0,O_ACCMODE) succeeds.) > > Thanks for testing. > > Now next question -- what do you actually want to achieve with passing > O_ACCMODE to open()? > > O_ACCMODE should primarily be used as a mask to use when extracting access > mode bits from fcntl(F_GETFL) call. ioctl-only open. It's an old weird part of /dev/fd0 ABI and if you are playing with that driver, you'd better bother to check the actual userland talking to it. Rationale, IIRC, is that unlike the normal open() this one does *not* depend on formatted disk being there. Regularizing it ot of existence is not a good idea.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-13 14:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-14 20:50 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-15 09:10 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-15 13:50 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Al Viro <viro@ZenIV.linux.org.uk> - 2016-06-15 15:30 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-15 16:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-16 00:50 +0200
[PATCH] floppy: fix open(O_ACCMODE) for ioctl-only open Jiri Kosina <jikos@kernel.org> - 2016-06-16 10:00 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-16 01:10 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-16 01:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Joe Perches <joe@perches.com> - 2016-06-16 01:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Al Viro <viro@ZenIV.linux.org.uk> - 2016-06-14 21:10 +0200
csiph-web