Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1422237
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 |
| Date | 2016-06-14 21:10 +0200 |
| Message-ID | <rK1SN-yB-1@gated-at.bofh.it> (permalink) |
| References | <rIDIR-3tH-13@gated-at.bofh.it> <rJz0t-69B-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jun 13, 2016 at 02:15:15PM +0200, Jiri Kosina wrote:
> Hmm, could you please test with 09954bad448 reverted? (although I don't
> really have a good explanation currently how it'd be causing what you are
> observing).
I do, actually - ->f_mode on open(..., 3) contains neither FMODE_READ nor
FMODE_WRITE. So this
While at it, clean up a bit handling of !(mode & (FMODE_READ|FMODE_WRITE))
case and return EINVAL instead of succeeding as well.
is working as promised in commit message.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-13 14:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-14 20:50 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-15 09:10 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-15 13:50 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Al Viro <viro@ZenIV.linux.org.uk> - 2016-06-15 15:30 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-15 16:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-16 00:50 +0200
[PATCH] floppy: fix open(O_ACCMODE) for ioctl-only open Jiri Kosina <jikos@kernel.org> - 2016-06-16 10:00 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt <wim@djo.tudelft.nl> - 2016-06-16 01:10 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Jiri Kosina <jikos@kernel.org> - 2016-06-16 01:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Joe Perches <joe@perches.com> - 2016-06-16 01:20 +0200
Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Al Viro <viro@ZenIV.linux.org.uk> - 2016-06-14 21:10 +0200
csiph-web