Re: [PATCH 1/5] net: qlcnic: don't set unused function argument

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] net: qlcnic: don't set unused function argument
Date	2016-06-17 02:40 +0200
Message-ID	<rKPZf-7Fj-25@gated-at.bofh.it> (permalink)
References	<rKDOp-7Nv-7@gated-at.bofh.it> <rKDOq-7Nv-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 16 Jun 2016 13:38:22 +0200

> We get a warning for qlcnic_83xx_get_mac_address when building with
> "make W=1":
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c: In function 'qlcnic_83xx_get_mac_address':
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: error: parameter 'function' set but not used [-Werror=unused-but-set-parameter]
> 
> Clearly this is harmless, but there is also no point for setting
> the variable, so we can simply remove the assignment.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to net-next.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] net: qlcnic: don't set unused function argument Arnd Bergmann <arnd@arndb.de> - 2016-06-16 13:40 +0200
  RE: [PATCH 1/5] net: qlcnic: don't set unused function argument Rajesh Borundia <rajesh.borundia@qlogic.com> - 2016-06-16 16:00 +0200
  Re: [PATCH 1/5] net: qlcnic: don't set unused function argument David Miller <davem@davemloft.net> - 2016-06-17 02:40 +0200

csiph-web