[PATCH 1/5] net: qlcnic: don't set unused function argument

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH 1/5] net: qlcnic: don't set unused function argument
Date	2016-06-16 13:40 +0200
Message-ID	<rKDOq-7Nv-19@gated-at.bofh.it> (permalink)
References	<rKDOp-7Nv-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

We get a warning for qlcnic_83xx_get_mac_address when building with
"make W=1":

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c: In function 'qlcnic_83xx_get_mac_address':
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: error: parameter 'function' set but not used [-Werror=unused-but-set-parameter]

Clearly this is harmless, but there is also no point for setting
the variable, so we can simply remove the assignment.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index f9640d5ce6ba..bdbcd2b088a0 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -2159,7 +2159,6 @@ int qlcnic_83xx_get_mac_address(struct qlcnic_adapter *adapter, u8 *mac,
 	struct qlcnic_cmd_args cmd;
 	u32 mac_low, mac_high;
 
-	function = 0;
 	err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_MAC_ADDRESS);
 	if (err)
 		return err;
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] net: qlcnic: don't set unused function argument Arnd Bergmann <arnd@arndb.de> - 2016-06-16 13:40 +0200
  RE: [PATCH 1/5] net: qlcnic: don't set unused function argument Rajesh Borundia <rajesh.borundia@qlogic.com> - 2016-06-16 16:00 +0200
  Re: [PATCH 1/5] net: qlcnic: don't set unused function argument David Miller <davem@davemloft.net> - 2016-06-17 02:40 +0200

csiph-web