Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424307

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()
Date 2016-06-16 19:50 +0200
Message-ID <rKJAt-2T5-1@gated-at.bofh.it> (permalink)
References (5 earlier) <rKF3Q-8v4-21@gated-at.bofh.it> <rKGCB-14P-9@gated-at.bofh.it> <rKGCB-14P-7@gated-at.bofh.it> <rKGVY-1bI-5@gated-at.bofh.it> <rKH5D-1u6-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
> 
> > If not, do you want me to 'fix' this or just remove the comment?
> 
> It's not broken, so nothing to fix.

Its non obvious code, that's usually plenty reason to change it.

Geert, you maintain this stuff, what say you? Is there still a good
reason (like supporting ancient compilers that don't do "+d" for
example) to keep the code as is?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-16 12:10 +0200
  Re: [PATCH -v2 14/33] locking,m68k: Implement  atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 12:20 +0200
    Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 14:50 +0200
      Re: [PATCH -v2 14/33] locking,m68k: Implement  atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 15:00 +0200
        Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 15:00 +0200
          Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 16:40 +0200
            Re: [PATCH -v2 14/33] locking,m68k: Implement  atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 17:00 +0200
              Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 17:10 +0200
                Re: [PATCH -v2 14/33] locking,m68k: Implement  atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 19:50 +0200
                Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 21:20 +0200
                Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-16 22:00 +0200
          Re: [PATCH -v2 14/33] locking,m68k: Implement  atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 16:40 +0200
      Re: [PATCH -v2 14/33] locking,m68k: Implement  atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-17 17:50 +0200
        Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-20 19:50 +0200
          Re: [PATCH -v2 14/33] locking,m68k: Implement  atomic_fetch_{add,sub,and,or,xor}() Finn Thain <fthain@telegraphics.com.au> - 2016-06-21 06:40 +0200

csiph-web