Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423903
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() |
| Date | 2016-06-16 12:20 +0200 |
| Message-ID | <rKCyZ-75H-13@gated-at.bofh.it> (permalink) |
| References | <rEPfz-1vx-3@gated-at.bofh.it> <rEPfz-1vx-1@gated-at.bofh.it> <rKCpj-72x-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 16, 2016 at 12:08:27PM +0200, Geert Uytterhoeven wrote:
> > #ifdef CONFIG_RMW_INSNS
> >
> > +/*
> > + * Am I reading these CAS loops right in that %2 is the old value and the first
> > + * iteration uses an uninitialized value?
> > + *
> > + * Would it not make sense to add: tmp = atomic_read(v); to avoid this?
> > + */
> > +
> > #define ATOMIC_OP_RETURN(op, c_op, asm_op) \
> > static inline int atomic_##op##_return(int i, atomic_t *v) \
> > { \
>
> Do we want the above comment in the code?
I figured it would not hurt; is this indeed the case, do we want to fix
it? I can do a follow up patch clarifying the situation.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-16 12:10 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 12:20 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 14:50 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 15:00 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 15:00 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 16:40 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 17:00 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 17:10 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 19:50 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-16 21:20 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-16 22:00 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-16 16:40 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Peter Zijlstra <peterz@infradead.org> - 2016-06-17 17:50 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Andreas Schwab <schwab@linux-m68k.org> - 2016-06-20 19:50 +0200
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() Finn Thain <fthain@telegraphics.com.au> - 2016-06-21 06:40 +0200
csiph-web