Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1424044

Re: [PATCH v2 0/3] firmware: scpi: add device power domain support

From "Jon Medhurst (Tixy)" <tixy@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 0/3] firmware: scpi: add device power domain support
Date 2016-06-16 15:20 +0200
Message-ID <rKFnc-pe-19@gated-at.bofh.it> (permalink)
References <rKCSm-7c3-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 2016-06-16 at 11:37 +0100, Sudeep Holla wrote:
> This series add support for SCPI based device device power state
> management using genpd.
> 
> Regards,
> Sudeep
> 
> v1[1]->v2:
> 	- Fixed the endianness handling in scpi_device_get_power_state
> 	  as spotted by Tixy
> 	- Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf

You seemed to also have made some changes to the contents of the file,
is that deliberate? This is the diff...

--- a/drivers/firmware/scpi_pm_domain.c
+++ b/drivers/firmware/scpi_pd.c
@@ -27,7 +27,7 @@ struct scpi_pm_domain {
        struct generic_pm_domain genpd;
        struct scpi_ops *ops;
        u32 domain;
-       char name[20];
+       char name[30];
 };
 
 enum scpi_power_domain_state {
@@ -51,7 +51,7 @@ static int scpi_pd_power(struct scpi_pm_domain *pd,
bool power_on)
        if (ret)
                return ret;
 
-       return (state == pd->ops->device_get_power_state(pd->domain));
+       return !(state == pd->ops->device_get_power_state(pd->domain));
 }
 
 static int scpi_pd_power_on(struct generic_pm_domain *domain)

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] firmware: scpi: add device power domain support Sudeep Holla <sudeep.holla@arm.com> - 2016-06-16 12:40 +0200
  [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-16 12:40 +0200
    Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2016-06-16 19:50 +0200
      Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-16 20:00 +0200
        Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2016-06-17 10:20 +0200
          Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-17 10:40 +0200
          Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd Kevin Hilman <khilman@baylibre.com> - 2016-06-20 20:00 +0200
            Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-20 20:00 +0200
    Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-17 11:00 +0200
    Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-17 11:00 +0200
    Re: [PATCH v2 3/3] firmware: scpi: add device power domain support  using genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-20 21:30 +0200
    Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd Kevin Hilman <khilman@baylibre.com> - 2016-06-21 00:00 +0200
  [PATCH v2 2/3] Documentation: add DT bindings for ARM SCPI power domains Sudeep Holla <sudeep.holla@arm.com> - 2016-06-16 12:40 +0200
  [PATCH v2 1/3] firmware: arm_scpi: add support for device power state management Sudeep Holla <sudeep.holla@arm.com> - 2016-06-16 12:40 +0200
    Re: [PATCH v2 1/3] firmware: arm_scpi: add support for device power  state management "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2016-06-16 20:10 +0200
      Re: [PATCH v2 1/3] firmware: arm_scpi: add support for device power  state management Sudeep Holla <sudeep.holla@arm.com> - 2016-06-17 10:50 +0200
  Re: [PATCH v2 0/3] firmware: scpi: add device power domain support "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2016-06-16 15:20 +0200
    Re: [PATCH v2 0/3] firmware: scpi: add device power domain support Sudeep Holla <sudeep.holla@arm.com> - 2016-06-16 15:30 +0200
      Re: [PATCH v2 0/3] firmware: scpi: add device power domain support Ulf Hansson <ulf.hansson@linaro.org> - 2016-06-17 11:00 +0200
  Re: [PATCH v2 0/3] firmware: scpi: add device power domain support Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-06-17 17:30 +0200
    Re: [PATCH v2 0/3] firmware: scpi: add device power domain support Sudeep Holla <sudeep.holla@arm.com> - 2016-06-17 17:40 +0200
  Re: [PATCH v2 0/3] firmware: scpi: add device power domain support Kevin Hilman <khilman@baylibre.com> - 2016-06-20 20:00 +0200
    Re: [PATCH v2 0/3] firmware: scpi: add device power domain support Sudeep Holla <sudeep.holla@arm.com> - 2016-06-20 20:10 +0200

csiph-web