Re: [PATCH 15/21] time: Add time64_to_tm()

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 15/21] time: Add time64_to_tm()
Date	Tue, 14 Jun 2016 23:20:01 +0200
Message-ID	<rK3UB-1OB-3@gated-at.bofh.it> (permalink)
References	<rI0o9-1PH-9@gated-at.bofh.it> <rI0o9-1PH-11@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ySkhmLOpRbE1gI7P9Bq9IFdrTdYFXoxIUo0pzaPlJPo=; b=M84utIZGyn1c2Em82ksYScRHB98wZwdntXyCLSxp9UGHQ7g0E0eqqHCbIH+apULCUV sCYjghLhMtbjRbOObf5I6API46HvxYBV1i8PuKrDJm/GUagWnVDG6GQ1XIFATkG7ZBa3 UAeAiEBErCZ/8l4Gf0U5psAad6dflDi0cDf8w=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ySkhmLOpRbE1gI7P9Bq9IFdrTdYFXoxIUo0pzaPlJPo=; b=Yro5nLbUGib02RMwFs9WEPKiuNDYPFHS0/pN40BsZgy8PcUm1wDa2NATAoeYSSXu82 xjZL/edQ4vdJiQldwzK08xACvkkcNqGFCNWWoUKOTIznxDhdUxS0MP/ZSz1lMps77U1J q7I+uRVgZLUPK9zEOSnjIY3BYkf7z3UbXx4DwdE+juzy0v01RgwcbuLCU67HzF1eJmhx XwI0iNxBC+0tjUnTvDz356fwykH7Zu3WpELoJH8ZEHC33YSujJur4uRLHReIIh5SO2Ds LPvf0dSdEABrclS+UAVypq1zJYF25NfLi6T6swLgx570cc/qmfMr3zltaRg1Ug4IFaDg 6f+Q==
X-Gm-Message-State	ALyK8tLK2ufED5YB5txga90PxcVrfXKHT28kjOZZvmoaByr+zQq07KBX5X8d8I5S2GmyvgHPaoF/VZ09Lkgmqw8h
X-Received	by 10.202.72.139 with SMTP id v133mr12624370oia.108.1465939136214; Tue, 14 Jun 2016 14:18:56 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>, Al Viro <viro@zeniv.linux.org.uk>, Linus Torvalds <torvalds@linux-foundation.org>, y2038 Mailman List <y2038@lists.linaro.org>
X-Original-Date	Tue, 14 Jun 2016 14:18:55 -0700
X-Original-Message-ID	<CALAqxLWoXTLXcjaVv8HkNnepokMfJ7r-KDU-ORSzEhqbvtt-CA@mail.gmail.com>
X-Original-References	<1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-16-git-send-email-deepa.kernel@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1422341

Show key headers only | View raw

On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> time_to_tm() takes time_t as an argument.
> time_t is not y2038 safe.
> Add time64_to_tm() that takes time64_t as an argument
> which is y2038 safe.
> The plan is to eventually replace all calls to time_to_tm()
> by time64_to_tm().
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>

This looks sane to me. Are you hoping for me to queue this, or would
you like i to go though the fsdev maintainers with my ack?

In either case.

Acked-by: John Stultz <john.stultz@linaro.org>

thanks
-john

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 15/21] time: Add time64_to_tm() John Stultz <john.stultz@linaro.org> - 2016-06-14 23:20 +0200
  Re: [PATCH 15/21] time: Add time64_to_tm() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-15 19:50 +0200
    Re: [PATCH 15/21] time: Add time64_to_tm() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-17 23:00 +0200
      Re: [PATCH 15/21] time: Add time64_to_tm() Arnd Bergmann <arnd@arndb.de> - 2016-06-17 23:10 +0200
    Re: [PATCH 15/21] time: Add time64_to_tm() John Stultz <john.stultz@linaro.org> - 2016-06-17 23:00 +0200

csiph-web