Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1422341 > unrolled thread

Re: [PATCH 15/21] time: Add time64_to_tm()

Started byJohn Stultz <john.stultz@linaro.org>
First post2016-06-14 23:20 +0200
Last post2016-06-17 23:00 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 15/21] time: Add time64_to_tm() John Stultz <john.stultz@linaro.org> - 2016-06-14 23:20 +0200
    Re: [PATCH 15/21] time: Add time64_to_tm() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-15 19:50 +0200
      Re: [PATCH 15/21] time: Add time64_to_tm() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-17 23:00 +0200
        Re: [PATCH 15/21] time: Add time64_to_tm() Arnd Bergmann <arnd@arndb.de> - 2016-06-17 23:10 +0200
      Re: [PATCH 15/21] time: Add time64_to_tm() John Stultz <john.stultz@linaro.org> - 2016-06-17 23:00 +0200

#1422341 — Re: [PATCH 15/21] time: Add time64_to_tm()

FromJohn Stultz <john.stultz@linaro.org>
Date2016-06-14 23:20 +0200
SubjectRe: [PATCH 15/21] time: Add time64_to_tm()
Message-ID<rK3UB-1OB-3@gated-at.bofh.it>
On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> time_to_tm() takes time_t as an argument.
> time_t is not y2038 safe.
> Add time64_to_tm() that takes time64_t as an argument
> which is y2038 safe.
> The plan is to eventually replace all calls to time_to_tm()
> by time64_to_tm().
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>

This looks sane to me. Are you hoping for me to queue this, or would
you like i to go though the fsdev maintainers with my ack?

In either case.

Acked-by: John Stultz <john.stultz@linaro.org>

thanks
-john

[toc] | [next] | [standalone]


#1423263

FromDeepa Dinamani <deepa.kernel@gmail.com>
Date2016-06-15 19:50 +0200
Message-ID<rKn6V-5AD-11@gated-at.bofh.it>
In reply to#1422341
On Tue, Jun 14, 2016 at 2:18 PM, John Stultz <john.stultz@linaro.org> wrote:
> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>> time_to_tm() takes time_t as an argument.
>> time_t is not y2038 safe.
>> Add time64_to_tm() that takes time64_t as an argument
>> which is y2038 safe.
>> The plan is to eventually replace all calls to time_to_tm()
>> by time64_to_tm().
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>> Cc: John Stultz <john.stultz@linaro.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>
> This looks sane to me. Are you hoping for me to queue this, or would
> you like i to go though the fsdev maintainers with my ack?
>
> In either case.
>
> Acked-by: John Stultz <john.stultz@linaro.org>

This is only used by the scsi fnic driver.
I will separate these 2 patches from this CURRENT_TIME series and
then both the patches can be merged through the respective trees.

-Deepa

[toc] | [prev] | [next] | [standalone]


#1425467

FromDeepa Dinamani <deepa.kernel@gmail.com>
Date2016-06-17 23:00 +0200
Message-ID<rL91U-31m-13@gated-at.bofh.it>
In reply to#1423263
On Fri, Jun 17, 2016 at 1:52 PM, John Stultz <john.stultz@linaro.org> wrote:
> On Wed, Jun 15, 2016 at 10:44 AM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>> On Tue, Jun 14, 2016 at 2:18 PM, John Stultz <john.stultz@linaro.org> wrote:
>>> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>>>> time_to_tm() takes time_t as an argument.
>>>> time_t is not y2038 safe.
>>>> Add time64_to_tm() that takes time64_t as an argument
>>>> which is y2038 safe.
>>>> The plan is to eventually replace all calls to time_to_tm()
>>>> by time64_to_tm().
>>>>
>>>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>>>> Cc: John Stultz <john.stultz@linaro.org>
>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>
>>> This looks sane to me. Are you hoping for me to queue this, or would
>>> you like i to go though the fsdev maintainers with my ack?
>>>
>>> In either case.
>>>
>>> Acked-by: John Stultz <john.stultz@linaro.org>
>>
>> This is only used by the scsi fnic driver.
>> I will separate these 2 patches from this CURRENT_TIME series and
>> then both the patches can be merged through the respective trees.
>
> Sorry, this was not quite clear. I've gone ahead and queued this one
> patch for testing, but let me know and I'll drop it if its going
> through a different tree.

Ok.This works too.

Thanks,
Deepa

[toc] | [prev] | [next] | [standalone]


#1425480

FromArnd Bergmann <arnd@arndb.de>
Date2016-06-17 23:10 +0200
Message-ID<rL9bz-3jz-11@gated-at.bofh.it>
In reply to#1425467
On Friday, June 17, 2016 1:59:06 PM CEST Deepa Dinamani wrote:
> On Fri, Jun 17, 2016 at 1:52 PM, John Stultz <john.stultz@linaro.org> wrote:
> > On Wed, Jun 15, 2016 at 10:44 AM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> >> On Tue, Jun 14, 2016 at 2:18 PM, John Stultz <john.stultz@linaro.org> wrote:
> >>> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> >>>> time_to_tm() takes time_t as an argument.
> >>>> time_t is not y2038 safe.
> >>>> Add time64_to_tm() that takes time64_t as an argument
> >>>> which is y2038 safe.
> >>>> The plan is to eventually replace all calls to time_to_tm()
> >>>> by time64_to_tm().
> >>>>
> >>>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> >>>> Cc: John Stultz <john.stultz@linaro.org>
> >>>> Cc: Thomas Gleixner <tglx@linutronix.de>
> >>>
> >>> This looks sane to me. Are you hoping for me to queue this, or would
> >>> you like i to go though the fsdev maintainers with my ack?
> >>>
> >>> In either case.
> >>>
> >>> Acked-by: John Stultz <john.stultz@linaro.org>
> >>
> >> This is only used by the scsi fnic driver.
> >> I will separate these 2 patches from this CURRENT_TIME series and
> >> then both the patches can be merged through the respective trees.
> >
> > Sorry, this was not quite clear. I've gone ahead and queued this one
> > patch for testing, but let me know and I'll drop it if its going
> > through a different tree.
> 
> Ok.This works too.

Actually I have three more patches for other drivers that could use the
time64_to_tm() function. I'll post them next week and we can decide whether
we want to queue the driver changes on top (with the respective Ack).

	Arnd

[toc] | [prev] | [next] | [standalone]


#1425472

FromJohn Stultz <john.stultz@linaro.org>
Date2016-06-17 23:00 +0200
Message-ID<rL91U-31m-15@gated-at.bofh.it>
In reply to#1423263
On Wed, Jun 15, 2016 at 10:44 AM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> On Tue, Jun 14, 2016 at 2:18 PM, John Stultz <john.stultz@linaro.org> wrote:
>> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>>> time_to_tm() takes time_t as an argument.
>>> time_t is not y2038 safe.
>>> Add time64_to_tm() that takes time64_t as an argument
>>> which is y2038 safe.
>>> The plan is to eventually replace all calls to time_to_tm()
>>> by time64_to_tm().
>>>
>>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>>> Cc: John Stultz <john.stultz@linaro.org>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>
>> This looks sane to me. Are you hoping for me to queue this, or would
>> you like i to go though the fsdev maintainers with my ack?
>>
>> In either case.
>>
>> Acked-by: John Stultz <john.stultz@linaro.org>
>
> This is only used by the scsi fnic driver.
> I will separate these 2 patches from this CURRENT_TIME series and
> then both the patches can be merged through the respective trees.

Sorry, this was not quite clear. I've gone ahead and queued this one
patch for testing, but let me know and I'll drop it if its going
through a different tree.

thanks
-john

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web