Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1422262

Re: [PATCH V5] irq: Track the interrupt timings

Show key headers only | View raw

On 06/14/2016 08:11 PM, Thomas Gleixner wrote:
> On Tue, 14 Jun 2016, Nicolas Pitre wrote:
>> What about simply this:
>>
>> void __handle_timings(struct irq_desc *desc)
>> {
>> 	struct irq_timings *timings = this_cpu_ptr(desc->timings);
>> 	timings->w_index = (timings->w_index + 1) & IRQ_TIMINGS_MASK;
>> 	timings->values[timings->w_index] = local_clock();
>> }
>>
>> ?
>>
>> Then you could s/__handle_timings/__record_irq_time/ to better represent
>> what it does.  And both the difference and the summing of squares could
>> be done upon entering idle instead.
>
> And make it part of the handle_timings() inline to avoid the function call.

Ah yes, nice !


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V5] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-14 18:40 +0200
  Re: [PATCH V5] irq: Track the interrupt timings Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-06-14 19:50 +0200
    Re: [PATCH V5] irq: Track the interrupt timings Thomas Gleixner <tglx@linutronix.de> - 2016-06-14 20:20 +0200
      Re: [PATCH V5] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-14 22:00 +0200
      [PATCH V6] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-14 22:20 +0200
        Re: [PATCH V6] irq: Track the interrupt timings Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-06-14 22:40 +0200
        Re: [PATCH V6] irq: Track the interrupt timings Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:50 +0200
          [PATCH V7] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-17 19:20 +0200
            Re: [PATCH V7] irq: Track the interrupt timings Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 10:50 +0200
              Re: [PATCH V7] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-23 11:40 +0200
                Re: [PATCH V7] irq: Track the interrupt timings Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 12:20 +0200
                Re: [PATCH V7] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-23 15:20 +0200

csiph-web