Path: csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From: Daniel Lezcano <daniel.lezcano@linaro.org>
Newsgroups: linux.kernel
Subject: Re: [PATCH V5] irq: Track the interrupt timings
Date: Tue, 14 Jun 2016 22:00:02 +0200
Message-ID: <rK2Fc-Rz-5@gated-at.bofh.it>
References: <rJZxD-7jp-9@gated-at.bofh.it> <rK0Dn-80b-1@gated-at.bofh.it> <rK16q-8sH-25@gated-at.bofh.it>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 28
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1422262

On 06/14/2016 08:11 PM, Thomas Gleixner wrote:
> On Tue, 14 Jun 2016, Nicolas Pitre wrote:
>> What about simply this:
>>
>> void __handle_timings(struct irq_desc *desc)
>> {
>> 	struct irq_timings *timings = this_cpu_ptr(desc->timings);
>> 	timings->w_index = (timings->w_index + 1) & IRQ_TIMINGS_MASK;
>> 	timings->values[timings->w_index] = local_clock();
>> }
>>
>> ?
>>
>> Then you could s/__handle_timings/__record_irq_time/ to better represent
>> what it does.  And both the difference and the summing of squares could
>> be done upon entering idle instead.
>
> And make it part of the handle_timings() inline to avoid the function call.

Ah yes, nice !


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog