Groups > linux.kernel > #1420706

Re: [mmots-2016-06-09-16-49] sleeping function called from slab_alloc()

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [mmots-2016-06-09-16-49] sleeping function called from slab_alloc()
Date	2016-06-13 12:50 +0200
Message-ID	<rJxBn-56h-1@gated-at.bofh.it> (permalink)
References	<rInXr-10i-1@gated-at.bofh.it> <rIrol-2W0-5@gated-at.bofh.it> <rIrol-2W0-3@gated-at.bofh.it> <rICD7-2kv-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 10-06-16 14:59:16, Andrew Morton wrote:
> On Fri, 10 Jun 2016 11:55:54 +0200 mhocko <mhocko@suse.de> wrote:
> 
> > On 2016-06-10 11:50, Sergey Senozhatsky wrote:
> > > Hello,
> > > 
> > > forked from http://marc.info/?l=linux-mm&m=146553910928716&w=2
> > > 
> > > new_slab()->BUG->die()->exit_signals() can be called from atomic
> > > context: local IRQs disabled in slab_alloc().
> > 
> > I have sent a patch to drop the BUG() from that path today. It
> > is just too aggressive way to react to a non-critical bug.
> > See 
> > http://lkml.kernel.org/r/1465548200-11384-2-git-send-email-mhocko@kernel.org
> 
> Doesn't this simply mean that Sergey's workload will blurt a pr_warn()
> rather than a BUG()?  That still needs fixing.  Confused.

Yes that should be fixed by
http://lkml.kernel.org/r/20160610074223.GC32285@dhcp22.suse.cz

which prevents from using a wrong GFP...

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [mmots-2016-06-09-16-49] sleeping function called from  slab_alloc() Michal Hocko <mhocko@kernel.org> - 2016-06-13 12:50 +0200

csiph-web