Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420511
| Path | csiph.com!goblin2!goblin.stu.neva.ru!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Linus Walleij <linus.walleij@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536 |
| Date | Mon, 13 Jun 2016 09:30:02 +0200 |
| Message-ID | <rJutQ-355-29@gated-at.bofh.it> (permalink) |
| References | <rI0Rb-22f-5@gated-at.bofh.it> |
| X-Original-To | Vignesh R <vigneshr@ti.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KGjGXU/DMMjndDBAqYt0GPrDsJtwUCcqgBMHpSjn+Bs=; b=ENlob4WZrCuQbOZ33bHDtp+vrCquC0kWiH7xhuiwWRBEDDDN4CpxupzngKIGztzcf6 x9EwC7HGoCpyQlXojsthSmFWEQw06vEmnwt0n2uc31l8fS7A/4pNix0ubxLR6hQHczgp yPuXq2i5YunLJO6Qjw2cn5EkozucB5win3vxU= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KGjGXU/DMMjndDBAqYt0GPrDsJtwUCcqgBMHpSjn+Bs=; b=aWT8LkeSxsmJc1ccrMakJBSSDXsTxAStyP3+FO+YSZPhQtlwmd+g0v9P7JVPnSNc+D SH0975Z+mFI3VMpLexZ7RYW2ELwV1Hjt/27hLfDTadbqcoEMnO0aCRhMDS11c8L/pVFp ovUkEbemCAreeaJS4IJpt5Tv24H/siDKIlCjiBhtBIrLlxEUWKCKxdF89yjiLWP8Nr8h PEZjZhGgdkQ+s8u2LR3kKxcoZFhM37IaG1KgPZ3emV2AM3XjlBIAKYvPpuuSvVgdB0Kx OL9ZgRRc9QghAkGXV9NUS9I/399VW3B6WF7d6sQH75dZD7eUsEcOYp2zUcL5DpeBR7Ml K34A== |
| X-Gm-Message-State | ALyK8tJH83K52ZgVDG+53cwVvxAhzVJyX3CbVXHX8/6RguQ3T+XpsON+QQHHJECBw4MpBYu8M0SsC+NoK00vgD4X |
| X-Received | by 10.202.168.131 with SMTP id r125mr6774834oie.40.1465802548323; Mon, 13 Jun 2016 00:22:28 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 19 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Alexandre Courbot <gnurou@gmail.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Mon, 13 Jun 2016 09:22:27 +0200 |
| X-Original-Message-ID | <CACRpkdYZEbefjr-iHT3yahkBovFuE2Ofvr8_Mr+X++pJSVwzfA@mail.gmail.com> |
| X-Original-References | <20160609053204.32398-1-vigneshr@ti.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1420511 |
Show key headers only | View raw
On Thu, Jun 9, 2016 at 7:32 AM, Vignesh R <vigneshr@ti.com> wrote: > NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and > hence results in 0 banks for PCA9536 which has just 4 gpios. This is > wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized > PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in > NBANK(). > > Cc: stable@vger.kernel.org > Signed-off-by: Vignesh R <vigneshr@ti.com> Patch applied. Is this really a regression or affecting systems in development? Which machine/device tree makes this problematic? Yours, Linus Walleij
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536 Linus Walleij <linus.walleij@linaro.org> - 2016-06-13 09:30 +0200 Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536 Vignesh R <vigneshr@ti.com> - 2016-06-13 11:10 +0200
csiph-web