Groups > linux.kernel > #1420511

Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536
Date	2016-06-13 09:30 +0200
Message-ID	<rJutQ-355-29@gated-at.bofh.it> (permalink)
References	<rI0Rb-22f-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 9, 2016 at 7:32 AM, Vignesh R <vigneshr@ti.com> wrote:

> NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
> hence results in 0 banks for PCA9536 which has just 4 gpios. This is
> wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
> PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
> NBANK().
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Vignesh R <vigneshr@ti.com>

Patch applied.

Is this really a regression or affecting systems in development?

Which machine/device tree makes this problematic?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536 Linus Walleij <linus.walleij@linaro.org> - 2016-06-13 09:30 +0200
  Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536 Vignesh R <vigneshr@ti.com> - 2016-06-13 11:10 +0200

csiph-web