Groups > linux.kernel > #1420412

Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by default

Path	csiph.com!weretis.net!feeder6.news.weretis.net!news.glorb.com!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by default
Date	Mon, 13 Jun 2016 04:40:01 +0200
Message-ID	<rJpXb-7L-1@gated-at.bofh.it> (permalink)
References	<rDUAF-67E-5@gated-at.bofh.it> <rDUAF-67E-15@gated-at.bofh.it> <rHvu3-7bR-51@gated-at.bofh.it>
X-Original-To	Auger Eric <eric.auger@redhat.com>, kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@linaro.org
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	linux-acpi@vger.kernel.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal <b.reynal@virtualopensystems.com>, Alex Williamson <alex.williamson@redhat.com>, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 12 Jun 2016 22:32:37 -0400
X-Original-Message-ID	<575E1B45.3070406@codeaurora.org>
X-Original-References	<1464472878-27176-1-git-send-email-okaya@codeaurora.org> <1464472878-27176-7-git-send-email-okaya@codeaurora.org> <c3538f11-d206-1ffc-35e0-ff5a7672c7d9@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1420412

Show key headers only | View raw

On 6/7/2016 3:59 PM, Auger Eric wrote:
>> -	vfio_platform_get_reset(vdev);
>> > +	ret = vfio_platform_get_reset(vdev);
>> > +	if (ret && vdev->reset_required) {
>> > +		pr_err("vfio: no reset function found for device %s\n",
>> > +		       vdev->name);
>> > +		iommu_group_put(group);
>> > +		return ret;
> nit: in case you respin you can factorize the group put and return ret in a goto label
> (since also used above).
> 
> Besides Reviewed-by: Eric Auger <eric.auger@redhat.com>

thanks, done. I'll respin with your request.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by  default Auger Eric <eric.auger@redhat.com> - 2016-06-07 22:10 +0200
  Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by  default Sinan Kaya <okaya@codeaurora.org> - 2016-06-13 04:40 +0200

csiph-web