Groups > linux.kernel > #1420412

Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by default

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by default
Date	2016-06-13 04:40 +0200
Message-ID	<rJpXb-7L-1@gated-at.bofh.it> (permalink)
References	<rDUAF-67E-5@gated-at.bofh.it> <rDUAF-67E-15@gated-at.bofh.it> <rHvu3-7bR-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 6/7/2016 3:59 PM, Auger Eric wrote:
>> -	vfio_platform_get_reset(vdev);
>> > +	ret = vfio_platform_get_reset(vdev);
>> > +	if (ret && vdev->reset_required) {
>> > +		pr_err("vfio: no reset function found for device %s\n",
>> > +		       vdev->name);
>> > +		iommu_group_put(group);
>> > +		return ret;
> nit: in case you respin you can factorize the group put and return ret in a goto label
> (since also used above).
> 
> Besides Reviewed-by: Eric Auger <eric.auger@redhat.com>

thanks, done. I'll respin with your request.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by  default Auger Eric <eric.auger@redhat.com> - 2016-06-07 22:10 +0200
  Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by  default Sinan Kaya <okaya@codeaurora.org> - 2016-06-13 04:40 +0200

csiph-web