Groups > linux.kernel > #1420231

Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request
Date	2016-06-12 13:10 +0200
Message-ID	<rJbrb-7Vg-13@gated-at.bofh.it> (permalink)
References	<rFAHv-6o5-13@gated-at.bofh.it> <rFAHv-6o5-21@gated-at.bofh.it> <rHmAq-1vx-53@gated-at.bofh.it> <rIvUZ-5O9-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 10, 2016 at 04:43:09PM +0200, LABBE Corentin wrote:
>
> So I need to split do_one_request to cipher_one_request/hash_one_request.
> Same with prepare_request to prepare_hash_request/prepare_cipher_request.
> With the choice of each function done in crypto_engine.c.

Yes.  As a general rule we should make sure that the API exposed
to driver authors is strongly typed so that they don't have to do
casts at all.

> Since this modification need to add <crypto/hash.h> to algapi.h, I think it is necessary to move all crypto engine stuff to crypto/engine.h
> Do you agree ?

That sounds like a good idea.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/1] crypto: engine: permit to enqueue ashash_request LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-06-02 15:20 +0200
  [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-06-02 15:20 +0200
    Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-07 12:40 +0200
      Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-06-10 16:50 +0200
        Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-12 13:10 +0200

csiph-web