Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1421621

Re: [PATCH 2/2] pinctrl: max77620: select PINMUX

Show all headers | View raw

On Mon, Jun 13, 2016 at 5:18 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The recently added max77620 driver fails to build when CONFIG_PINMUX
> is not set:
>
> pinctrl/pinctrl-max77620.c:272:21: error: variable 'max77620_pinmux_ops' has initializer but incomplete type
>  static const struct pinmux_ops max77620_pinmux_ops = {
>                      ^~~~~~~~~~
> pinctrl/pinctrl-max77620.c:273:2: error: unknown field 'get_functions_count' specified in initializer
>
> This adds the Kconfig 'select' statement that was clearly meant
> to be there and is used in all other pinmux drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] pinctrl: fix incorrect inline keyword in multiple drivers Arnd Bergmann <arnd@arndb.de> - 2016-06-13 17:30 +0200
  [PATCH 2/2] pinctrl: max77620: select PINMUX Arnd Bergmann <arnd@arndb.de> - 2016-06-13 17:30 +0200
    Re: [PATCH 2/2] pinctrl: max77620: select PINMUX Linus Walleij <linus.walleij@linaro.org> - 2016-06-14 09:00 +0200
  Re: [PATCH 1/2] pinctrl: fix incorrect inline keyword in multiple drivers Linus Walleij <linus.walleij@linaro.org> - 2016-06-14 09:00 +0200

csiph-web