Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1421000

[PATCH 2/2] pinctrl: max77620: select PINMUX

Show all headers | View raw

The recently added max77620 driver fails to build when CONFIG_PINMUX
is not set:

pinctrl/pinctrl-max77620.c:272:21: error: variable 'max77620_pinmux_ops' has initializer but incomplete type
 static const struct pinmux_ops max77620_pinmux_ops = {
                     ^~~~~~~~~~
pinctrl/pinctrl-max77620.c:273:2: error: unknown field 'get_functions_count' specified in initializer

This adds the Kconfig 'select' statement that was clearly meant
to be there and is used in all other pinmux drivers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index ea25eeeceef1..78c9ed277a77 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -210,6 +210,7 @@ config PINCTRL_COH901
 config PINCTRL_MAX77620
 	tristate "MAX77620/MAX20024 Pincontrol support"
 	depends on MFD_MAX77620
+	select PINMUX
 	select GENERIC_PINCONF
 	help
 	  Say Yes here to enable Pin control support for Maxim PMIC MAX77620.
-- 
2.7.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] pinctrl: fix incorrect inline keyword in multiple drivers Arnd Bergmann <arnd@arndb.de> - 2016-06-13 17:30 +0200
  [PATCH 2/2] pinctrl: max77620: select PINMUX Arnd Bergmann <arnd@arndb.de> - 2016-06-13 17:30 +0200
    Re: [PATCH 2/2] pinctrl: max77620: select PINMUX Linus Walleij <linus.walleij@linaro.org> - 2016-06-14 09:00 +0200
  Re: [PATCH 1/2] pinctrl: fix incorrect inline keyword in multiple drivers Linus Walleij <linus.walleij@linaro.org> - 2016-06-14 09:00 +0200

csiph-web