Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

From	Xing Zheng <zhengxing@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399
Date	2016-06-14 05:10 +0200
Message-ID	<rJMTL-7lq-9@gated-at.bofh.it> (permalink)
References	<rJabL-6Xa-5@gated-at.bofh.it> <rJlgT-5q8-41@gated-at.bofh.it> <rJqzT-A7-1@gated-at.bofh.it> <rJJMd-50f-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Doug,

On 2016年06月14日 07:46, Doug Anderson wrote:
>
> Even if it's not much power, it seems like we should still turn it off
> and on in the right place.  Unless I'm mistaken it should be such a
> simple patch provide the clock to the right driver and then get the
> clock when appropriate.
Yes, I talked with Yakir and we intent to enable/disable the 
pclk_vio_grf in video drivers,
so this patch will be dropped.
>> I will refer the latest TRM to update a new patch for always enable these
>> GRFs.
> Does that mean you're going to make these all critical clocks?  That
> doesn't sound so great...
>
> -Doug
Maybe, I heard that they are removed in the updated TRM, but I have not 
got the TRM yet.
I will double check it, and it seems that you do not agree to remove 
these clock...

Thanks.

-- 
- Xing Zheng

Thread

[PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399 Xing Zheng <zhengxing@rock-chips.com> - 2016-06-12 11:50 +0200
  Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399 Doug Anderson <dianders@chromium.org> - 2016-06-12 23:40 +0200
    Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the  RK3399 Xing Zheng <zhengxing@rock-chips.com> - 2016-06-13 05:20 +0200
      Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the  RK3399 Xing Zheng <zhengxing@rock-chips.com> - 2016-06-13 05:40 +0200
      Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399 Doug Anderson <dianders@chromium.org> - 2016-06-14 01:50 +0200
        Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the  RK3399 Xing Zheng <zhengxing@rock-chips.com> - 2016-06-14 05:10 +0200
          Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399 Doug Anderson <dianders@chromium.org> - 2016-06-14 05:50 +0200
            Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399 Heiko Stübner <heiko@sntech.de> - 2016-06-14 08:50 +0200

csiph-web