Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1421032

[PATCH 4/7] random: properly align get_random_int_hash

Show all headers | View raw

From: Eric Biggers <ebiggers3@gmail.com>

get_random_long() reads from the get_random_int_hash array using an
unsigned long pointer.  For this code to be guaranteed correct on all
architectures, the array must be aligned to an unsigned long boundary.

Cc: stable@kernel.org
Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 drivers/char/random.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 64e35a4..83f5cd0 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1778,13 +1778,15 @@ int random_int_secret_init(void)
 	return 0;
 }
 
+static DEFINE_PER_CPU(__u32 [MD5_DIGEST_WORDS], get_random_int_hash)
+		__aligned(sizeof(unsigned long));
+
 /*
  * Get a random word for internal kernel use only. Similar to urandom but
  * with the goal of minimal entropy pool depletion. As a result, the random
  * value is not cryptographically secure but for several uses the cost of
  * depleting entropy is too high
  */
-static DEFINE_PER_CPU(__u32 [MD5_DIGEST_WORDS], get_random_int_hash);
 unsigned int get_random_int(void)
 {
 	__u32 *hash;
-- 
2.5.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH-v4 0/7] random: replace urandom pool with a CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-13 17:50 +0200
  [PATCH 7/7] random: add backtracking protection to the CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-13 17:50 +0200
  [PATCH 5/7] random: replace non-blocking pool with a Chacha20-based CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-13 18:00 +0200
    Re: [PATCH 5/7] random: replace non-blocking pool with a Chacha20-based CRNG Stephan Mueller <smueller@chronox.de> - 2016-06-13 20:10 +0200
      Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-13 21:10 +0200
    Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-15 17:00 +0200
      Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-20 01:20 +0200
        Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-20 03:30 +0200
          Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-20 07:10 +0200
            Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-20 08:10 +0200
              Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-20 17:10 +0200
                Re: [PATCH 5/7] random: replace non-blocking pool with a Chacha20-based CRNG Stephan Mueller <smueller@chronox.de> - 2016-06-20 18:50 +0200
                Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG "H. Peter Anvin" <hpa@zytor.com> - 2016-06-20 22:40 +0200
                Re: [PATCH 5/7] random: replace non-blocking pool with a  Chacha20-based CRNG Theodore Ts'o <tytso@mit.edu> - 2016-06-21 01:50 +0200
  [PATCH 1/7] random: initialize the non-blocking pool via add_hwgenerator_randomness() Theodore Ts'o <tytso@mit.edu> - 2016-06-13 18:00 +0200
  [PATCH 2/7] random: print a warning for the first ten uninitialized random users Theodore Ts'o <tytso@mit.edu> - 2016-06-13 18:00 +0200
  [PATCH 6/7] random: make /dev/urandom scalable for silly userspace programs Theodore Ts'o <tytso@mit.edu> - 2016-06-13 18:00 +0200
  [PATCH 3/7] random: add interrupt callback to VMBus IRQ handler Theodore Ts'o <tytso@mit.edu> - 2016-06-13 18:00 +0200
  [PATCH 4/7] random: properly align get_random_int_hash Theodore Ts'o <tytso@mit.edu> - 2016-06-13 18:00 +0200

csiph-web