Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420127
| From | Aaron Lu <aaron.lu@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC |
| Date | 2016-06-12 04:20 +0200 |
| Message-ID | <rJ3ah-2KN-3@gated-at.bofh.it> (permalink) |
| References | <rILwJ-8uU-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/11/2016 03:25 PM, Bin Gao wrote:
> This patch adds operation region driver for Intel BXT WhiskeyCove
> PMIC. The register mapping is done as per the BXT WC data sheet.
>
> Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> Signed-off-by: Bin Gao <bin.gao@intel.com>
> ---
> +static int __init intel_bxtwc_pmic_opregion_driver_init(void)
> +{
> + return platform_driver_register(&intel_bxtwc_pmic_opregion_driver);
> +}
> +
> +module_init(intel_bxtwc_pmic_opregion_driver_init);
Last time Paul suggests device_initcall instead of module_init here:
commit 75829dcf10862966f52716f2d67ac1c1b1eb486b
Author: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Mon Feb 15 00:27:51 2016 -0500
drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular
Perhaps you should do the same.
Thanks,
Aaron
> +
> +MODULE_DESCRIPTION("BXT WhiskeyCove ACPI opregion driver");
> +MODULE_LICENSE("GPL");
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC Bin Gao <bin.gao@linux.intel.com> - 2016-06-11 09:30 +0200
Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC Aaron Lu <aaron.lu@intel.com> - 2016-06-12 04:20 +0200
Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC Bin Gao <bin.gao@linux.intel.com> - 2016-06-13 19:40 +0200
csiph-web