Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420128

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

From Yakir Yang <ykk@rock-chips.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding
Date 2016-06-12 04:20 +0200
Message-ID <rJ3ah-2KN-11@gated-at.bofh.it> (permalink)
References <rHKjn-86P-9@gated-at.bofh.it> <rHKjn-86P-29@gated-at.bofh.it> <rIuYW-5ct-25@gated-at.bofh.it> <rIxN7-71n-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 06/11/2016 12:40 AM, Doug Anderson wrote:
> Rob,
>
> On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote:
>> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
>>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
>>> connected using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>>>
>>>   .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> new file mode 100644
>>> index 0000000..81938c0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> @@ -0,0 +1,7 @@
>>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
>>> +
>>> +Required properties:
>>> +- compatible: should be "sharp,lq123p1jx31,"
>>                                               ^
>> Need to drop the comma.
> Thanks for catching!

Done,

>
>> No regulators or resets or pwms?
> Could be more explicit I guess, but Yakir does say:
>
>> This binding is compatible with the simple-panel binding, which is specified
>> in simple-panel.txt in this directory.
> In that document it shows:
>
> Required properties:
> - power-supply: regulator to provide the supply voltage
>
> Optional properties:
> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> - enable-gpios: GPIO pin to enable or disable the panel
> - backlight: phandle of the backlight device attached to the panel
>
>
> In general Yakir's bindings document match a huge chunk of the current
> existing bindings.  Do this:
>    cd Documentation/devicetree/bindings/display/panel
>    grep -C20 "This binding is compatible with the simple-panel" *
>
> You'll find a huge chunk of files which are rather formulaic.  It
> might make sense to just have one file and a list of panels which are
> simple panels?
>
>
> -Doug
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang <ykk@rock-chips.com> - 2016-06-08 14:00 +0200
  [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel Yakir Yang <ykk@rock-chips.com> - 2016-06-08 14:00 +0200
    Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp  LQ123P1JX31 2400x1600 panel Doug Anderson <dianders@chromium.org> - 2016-06-08 18:40 +0200
      Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp  LQ123P1JX31 2400x1600 panel Doug Anderson <dianders@chromium.org> - 2016-06-10 18:20 +0200
        Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp  LQ123P1JX31 2400x1600 panel Yakir Yang <ykk@rock-chips.com> - 2016-06-12 04:20 +0200
  [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Yakir Yang <ykk@rock-chips.com> - 2016-06-08 14:00 +0200
    Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG  LP097QX1-SPA1 2048x1536 panel Emil Velikov <emil.l.velikov@gmail.com> - 2016-06-08 14:30 +0200
      Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG  LP097QX1-SPA1 2048x1536 panel Thierry Reding <thierry.reding@gmail.com> - 2016-06-10 15:30 +0200
      Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG  LP097QX1-SPA1 2048x1536 panel Yakir Yang <ykk@rock-chips.com> - 2016-06-12 04:10 +0200
  [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang <ykk@rock-chips.com> - 2016-06-08 14:00 +0200
    Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Doug Anderson <dianders@chromium.org> - 2016-06-08 18:40 +0200
    Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Rob Herring <robh@kernel.org> - 2016-06-10 15:50 +0200
      Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Doug Anderson <dianders@chromium.org> - 2016-06-10 18:50 +0200
        Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Rob Herring <robh@kernel.org> - 2016-06-10 20:00 +0200
          Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Doug Anderson <dianders@chromium.org> - 2016-06-10 20:10 +0200
        Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang <ykk@rock-chips.com> - 2016-06-12 04:20 +0200
  [PATCH v2 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding Yakir Yang <ykk@rock-chips.com> - 2016-06-08 14:00 +0200
  [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang <ykk@rock-chips.com> - 2016-06-08 14:00 +0200
    Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung  LSN122DL01-C01 2560x1600 panel Stéphane Marchesin <stephane.marchesin@gmail.com> - 2016-06-10 02:10 +0200
      Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung  LSN122DL01-C01 2560x1600 panel Yakir Yang <ykk@rock-chips.com> - 2016-06-12 04:10 +0200

csiph-web