Groups > linux.kernel > #1419656

Re: PROBLEM: Resume form hibernate broken by setting NX on gap

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: PROBLEM: Resume form hibernate broken by setting NX on gap
Date	2016-06-10 20:20 +0200
Message-ID	<rIzce-86w-3@gated-at.bofh.it> (permalink)
References	(6 earlier) <rB0VY-3pl-13@gated-at.bofh.it> <rBig9-5UY-3@gated-at.bofh.it> <rBig9-5UY-1@gated-at.bofh.it> <rIz2y-81e-33@gated-at.bofh.it> <rIz2y-81e-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hey,

On 10/06/16 12:09 PM, Kees Cook wrote:
>> restore_code: ffff880157c3b000
>> jump_addr: ffffffff81446be0
>>
>>
>> diff --git a/arch/x86/power/hibernate_64.c b/arch/x86/power/hibernate_64.c
>> index 009947d..6efedb7 100644
>> --- a/arch/x86/power/hibernate_64.c
>> +++ b/arch/x86/power/hibernate_64.c
>> @@ -92,6 +92,9 @@ int swsusp_arch_resume(void)
>>         memcpy(relocated_restore_code, &core_restore_code,
>>                &restore_registers - &core_restore_code);
>>
>> +       pr_info("restore_code: %p\n", relocated_restore_code);
>> +       pr_info("jump_addr: %lx\n", restore_jump_address);
>> +
> 
> Also interesting would be the "relocated_restore_code" address, as
> well as a dump of /sys/kernel/debug/kernel_page_tables (from
> CONFIG_X86_PTDUMP).

Is that not what I printed? If not, can you give me a better hint as to
what you're looking for so I can spin another kernel? I'll also provide
the kernel_page_tables once I do that.

> I'm baffled by the problem, but the best I can understand is the the
> relocated_restore_code range isn't executable (which should be visible
> from finding it in /sys/kernel/debug/kernel_page_tables), but I don't
> see how to solve that since my original patch didn't work.

Yeah this is definitely a baffling problem.

Thanks,

Logan

Thread

Re: PROBLEM: Resume form hibernate broken by setting NX on gap Kees Cook <keescook@chromium.org> - 2016-06-10 20:10 +0200
  Re: PROBLEM: Resume form hibernate broken by setting NX on gap Kees Cook <keescook@chromium.org> - 2016-06-10 20:20 +0200
  Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-10 20:20 +0200
  Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-10 23:30 +0200
    Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 00:30 +0200
      Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 00:30 +0200
        Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 02:10 +0200
          Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 03:50 +0200
            Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 13:50 +0200
              Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-11 18:40 +0200
            Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-11 19:50 +0200
              Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-12 03:10 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-12 06:50 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-12 16:30 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-12 18:20 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-13 15:40 +0200
      Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-11 00:30 +0200

csiph-web