Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1419741

Re: PROBLEM: Resume form hibernate broken by setting NX on gap

Show all headers | View raw

On Friday, June 10, 2016 11:09:22 AM Kees Cook wrote:
> On Thu, Jun 9, 2016 at 9:14 PM, Logan Gunthorpe <logang@deltatee.com> wrote:
> > Hey,
> >
> > I've still be trying to figure this out as I have time.
> >
> > I tried printing a couple restore addresses and nothing I can find seems
> > anywhere near the rodata/ex_table boundary.
> >
> > I tried with the (badly formatted) below and got the following. Nothing too
> > surprising. I've attached a kallsyms that matches the kernel for reference.
> >
> > restore_code: ffff880157c3b000
> > jump_addr: ffffffff81446be0
> >
> >
> > diff --git a/arch/x86/power/hibernate_64.c b/arch/x86/power/hibernate_64.c
> > index 009947d..6efedb7 100644
> > --- a/arch/x86/power/hibernate_64.c
> > +++ b/arch/x86/power/hibernate_64.c
> > @@ -92,6 +92,9 @@ int swsusp_arch_resume(void)
> >         memcpy(relocated_restore_code, &core_restore_code,
> >                &restore_registers - &core_restore_code);
> >
> > +       pr_info("restore_code: %p\n", relocated_restore_code);
> > +       pr_info("jump_addr: %lx\n", restore_jump_address);
> > +
> 
> Also interesting would be the "relocated_restore_code" address, as
> well as a dump of /sys/kernel/debug/kernel_page_tables (from
> CONFIG_X86_PTDUMP).
> 
> I'm baffled by the problem, but the best I can understand is the the
> relocated_restore_code range isn't executable (which should be visible
> from finding it in /sys/kernel/debug/kernel_page_tables), but I don't
> see how to solve that since my original patch didn't work.
> 
> Rafael, is this something you have time to look at quickly?

Well, not really, but I'll do my best to look at it in the next few days.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: PROBLEM: Resume form hibernate broken by setting NX on gap Kees Cook <keescook@chromium.org> - 2016-06-10 20:10 +0200
  Re: PROBLEM: Resume form hibernate broken by setting NX on gap Kees Cook <keescook@chromium.org> - 2016-06-10 20:20 +0200
  Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-10 20:20 +0200
  Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-10 23:30 +0200
    Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 00:30 +0200
      Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 00:30 +0200
        Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 02:10 +0200
          Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 03:50 +0200
            Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-11 13:50 +0200
              Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-11 18:40 +0200
            Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-11 19:50 +0200
              Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-12 03:10 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-12 06:50 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-12 16:30 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-12 18:20 +0200
                Re: PROBLEM: Resume form hibernate broken by setting NX on gap "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-13 15:40 +0200
      Re: PROBLEM: Resume form hibernate broken by setting NX on gap Logan Gunthorpe <logang@deltatee.com> - 2016-06-11 00:30 +0200

csiph-web