Groups > linux.kernel > #1419580

Re: [PATCH 2/3] PCI: Use device_match_always()

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] PCI: Use device_match_always()
Date	2016-06-10 18:40 +0200
Message-ID	<rIxDs-6XO-39@gated-at.bofh.it> (permalink)
References	<rGXiG-1OJ-9@gated-at.bofh.it> <rGXiG-1OJ-7@gated-at.bofh.it> <rIxk5-6Qd-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jun 10, 2016 at 11:13:43AM -0500, Bjorn Helgaas wrote:
> On Mon, Jun 06, 2016 at 09:32:37AM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > There is now a common implementation for a match function that will
> > always match, so the PCI-specific implementation can be removed.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> I'm sort of OK with this.  It's clearly not going to break anything.
> 
> But I would far rather figure out a way to remove no_pci_devices()
> completely.  There's only one in-tree caller, and it's sort of
> dubious, although the idea was added by Linus (2bff5e94f1bf).

This is sort of a spin-off from another series that I sent out, which
introduced a common function that was used in far more places and has
a more clearly legitimate use. While working on that other series the
duplication here occurred to me, so I thought I'd remove it while at
it, even if there are only two occurrences.

> I suppose nowadays we would use ACPI or DMI to do this.  But I guess
> this is OK as-is.  It'd be pretty hard to find a PC110 to test any
> real driver changes.
> 
> I assume all three of these patches would get merged together by
> somebody else.

I was thinking Greg could take them through the driver core tree.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] PCI: Use device_match_always() Thierry Reding <thierry.reding@gmail.com> - 2016-06-06 09:40 +0200
  Re: [PATCH 2/3] PCI: Use device_match_always() Bjorn Helgaas <helgaas@kernel.org> - 2016-06-10 18:20 +0200
    Re: [PATCH 2/3] PCI: Use device_match_always() Thierry Reding <thierry.reding@gmail.com> - 2016-06-10 18:40 +0200

csiph-web