Groups > linux.kernel > #1419575

Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches
Date	2016-06-10 18:40 +0200
Message-ID	<rIxDs-6XO-37@gated-at.bofh.it> (permalink)
References	<rIgVX-4lJ-5@gated-at.bofh.it> <rIgVX-4lJ-13@gated-at.bofh.it> <rIjqO-6ed-19@gated-at.bofh.it> <rIwxH-6gP-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Jun 10, 2016 at 03:25:28PM +0000, Faccini, Bruno wrote:
> Hello,
> The intent of this patch is not to solve the corruptions for sure, but
> only to avoid the concerned MEs/small-MDs LNet structs to be quite
> frequently impacted due to their high allocation/free rate.

But that's not what the patch description said :(

And again, putting them in a separate cache is not going to save much of
anything, given that your caches might have been merged together anyway.

> This may also possibly help to save cycles due to high usage and
> contention when using a generic kmem_cache (when they stay separate
> from others, thanks for the precision!).

Have you measured this?

This isn't applicable for 4.7-rc at this time, _unless_ it fixes a bug,
which is why I pushed back on this.  If you want your own cache for
these variables, fine, I don't care, but that makes it a 4.8-rc1 patch
instead.

hope that helps explain things better,

greg k-h

Thread

[PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches James Simmons <jsimmons@infradead.org> - 2016-06-10 00:50 +0200
  Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in  own kmem_caches Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-10 03:30 +0200
    Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs  in own kmem_caches "Faccini, Bruno" <bruno.faccini@intel.com> - 2016-06-10 17:30 +0200
      Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in  own kmem_caches Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-10 18:40 +0200
        Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs  in own kmem_caches James Simmons <jsimmons@infradead.org> - 2016-06-15 05:10 +0200
          Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in  own kmem_caches Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-18 05:40 +0200

csiph-web