Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1425627

Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches
Date 2016-06-18 05:40 +0200
Message-ID <rLfh0-74e-13@gated-at.bofh.it> (permalink)
References (1 earlier) <rIgVX-4lJ-13@gated-at.bofh.it> <rIjqO-6ed-19@gated-at.bofh.it> <rIwxH-6gP-11@gated-at.bofh.it> <rIxDs-6XO-37@gated-at.bofh.it> <rK9nk-5ok-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jun 15, 2016 at 04:02:40AM +0100, James Simmons wrote:
> 
> > > This may also possibly help to save cycles due to high usage and
> > > contention when using a generic kmem_cache (when they stay separate
> > > from others, thanks for the precision!).
> > 
> > Have you measured this?
> > 
> > This isn't applicable for 4.7-rc at this time, _unless_ it fixes a bug,
> > which is why I pushed back on this.  If you want your own cache for
> > these variables, fine, I don't care, but that makes it a 4.8-rc1 patch
> > instead.
> > 
> > hope that helps explain things better,
> 
> As a side question when is the window to push patches of this class?
> Is it when 4.7-rc7 is merged to staging? 

You can send them to me anytime, I'll queue them up in my "-next" branch
to be merged in the next merge window.  Like I do for almost all lustre
patches that aren't bugfixes or regressions.

But I think you have a bigger problem here that you need to debug, using
a separate cache isn't going to solve that bug, only postpone you
finding it...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs  in own kmem_caches James Simmons <jsimmons@infradead.org> - 2016-06-15 05:10 +0200
  Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in  own kmem_caches Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-18 05:40 +0200

csiph-web