Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1419186

Re: [PATCH] usb: dwc3: fix runtime PM in error path

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 10/06/16 12:16, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@ti.com> writes:
>> If there is a failure after pm_runtime_enable/get_sync()
>> we need to call pm_runtime_disable/put_sync().
>>
>> Otherwise it will lead to an unbalanced pm_runtime_enable() on the
>> subsequent probe if the earlier probe bailed out due to -EPROBE_DEFER.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> 
> where is this supposed to be applied? You're not checking if

On your testing/next

> pm_runtime_get() failed at all.
> 

I'm not adding pm_runtime_get in my patch.
Just fixing up the failure path in core.c.

cheers,
-roger

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: dwc3: fix runtime PM in error path Roger Quadros <rogerq@ti.com> - 2016-06-10 11:00 +0200
  Re: [PATCH] usb: dwc3: fix runtime PM in error path Felipe Balbi <balbi@kernel.org> - 2016-06-10 11:20 +0200
    Re: [PATCH] usb: dwc3: fix runtime PM in error path Roger Quadros <rogerq@ti.com> - 2016-06-10 12:00 +0200
      Re: [PATCH] usb: dwc3: fix runtime PM in error path Felipe Balbi <balbi@kernel.org> - 2016-06-10 12:10 +0200
  [PATCH v2] usb: dwc3: fix runtime PM in error path Roger Quadros <rogerq@ti.com> - 2016-06-10 13:40 +0200
  [PATCH v2] usb: dwc3: fix runtime PM in error path Roger Quadros <rogerq@ti.com> - 2016-06-10 13:40 +0200

csiph-web