Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416645

Re: [PATCH] selftests/vm/compaction_test: fix write to restore nr_hugepages

Show all headers | View raw

On 6/7/16, 4:26 PM, "Mike Kravetz" <mike.kravetz@oracle.com> wrote:

>The write at the end of the test to restore nr_hugepages to its previous
>value is failing.  This is because it is trying to write the number of
>bytes in the char array as opposed to the number of bytes in the string.
>
>Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>---
> tools/testing/selftests/vm/compaction_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/testing/selftests/vm/compaction_test.c b/tools/testing/selftests/vm/compaction_test.c
>index 932ff57..00c4f65 100644
>--- a/tools/testing/selftests/vm/compaction_test.c
>+++ b/tools/testing/selftests/vm/compaction_test.c
>@@ -136,7 +136,7 @@ int check_compaction(unsigned long mem_free, unsigned int hugepage_size)
> 	printf("No of huge pages allocated = %d\n",
> 	       (atoi(nr_hugepages)));
> 
>-	if (write(fd, initial_nr_hugepages, sizeof(initial_nr_hugepages))
>+	if (write(fd, initial_nr_hugepages, strlen(initial_nr_hugepages))
> 	    != strlen(initial_nr_hugepages)) {
> 		perror("Failed to write to /proc/sys/vm/nr_hugepages\n");
> 		goto close_fd;
>-- 
>2.4.11
>


Looks good, thanks!

-Sri Jayaramappa

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] selftests/vm/compaction_test: fix write to restore nr_hugepages Mike Kravetz <mike.kravetz@oracle.com> - 2016-06-07 22:30 +0200
  Re: [PATCH] selftests/vm/compaction_test: fix write to restore  nr_hugepages "Jayaramappa, Srilakshmi" <sjayaram@akamai.com> - 2016-06-07 23:20 +0200

csiph-web