Re: [PATCH v5] r8152: Add support for setting pass through MAC address on RTL8153-AD

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date	2016-06-07 20:10 +0200
Message-ID	<rHtBU-61h-47@gated-at.bofh.it> (permalink)
References	<rHrgK-4rU-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi! Another problem which I found now:

On Tuesday 07 June 2016 10:33:47 Mario Limonciello wrote:
> +	ret = hex2bin(buf, obj->string.pointer + 9, 6);
> +	if (!(ret == 0 && is_valid_ether_addr(buf))) {
> +		netif_warn(tp, probe, tp->netdev,
> +			   "Invalid MAC when reading pass-thru MAC addr: "
> +			   "%pM\n",
> +			   buf);
> +		goto amacout;
> +	}

In case when hex2bin returns zero, but is_valid_ether_addr returns
false, this function returns also zero. And thats wrong, because error
occur.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-07 17:40 +0200
  Re: [PATCH v5] r8152: Add support for setting pass through MAC  address on RTL8153-AD Pali Rohár <pali.rohar@gmail.com> - 2016-06-07 20:10 +0200

csiph-web