Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs
Date	2016-06-07 18:40 +0200
Message-ID	<rHscN-51h-25@gated-at.bofh.it> (permalink)
References	<rFnAB-6CD-3@gated-at.bofh.it> <rFnKj-6FR-41@gated-at.bofh.it> <rGKlr-1mU-9@gated-at.bofh.it> <rHscN-51h-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/06/2016 at 01:40:47 -0700, Stephen Boyd wrote :
> Quoting Alexandre Belloni (2016-06-05 10:41:57)
> > Hi,
> > 
> > The main drawback of those patches is that they break the alignment
> > (checkpatch.pl --strict complains).
> 
> Didn't checkpatch --strict already warn on these files though? I'm not
> sure I've done anything to break the alignment style here.
> 

As you change the function return value, the function arguments are no
longer aligned with the opening parenthesis.
I would agree that keeping the alignment will make the change quit
bigger though.

> > 
> > On 01/06/2016 at 16:15:06 -0700, Stephen Boyd wrote :
> > > diff --git a/drivers/clk/berlin/berlin2-avpll.h b/drivers/clk/berlin/berlin2-avpll.h
> > > index a37f5068d299..17e311153b42 100644
> > > --- a/drivers/clk/berlin/berlin2-avpll.h
> > > +++ b/drivers/clk/berlin/berlin2-avpll.h
> > > @@ -19,17 +19,13 @@
> > >  #ifndef __BERLIN2_AVPLL_H
> > >  #define __BERLIN2_AVPLL_H
> > >  
> > > -struct clk;
> > > -
> > >  #define BERLIN2_AVPLL_BIT_QUIRK              BIT(0)
> > >  #define BERLIN2_AVPLL_SCRAMBLE_QUIRK BIT(1)
> > >  
> > > -struct clk * __init
> > > -berlin2_avpll_vco_register(void __iomem *base, const char *name,
> > > +int berlin2_avpll_vco_register(void __iomem *base, const char *name,
> > 
> > This is missing __init.
> 
> Ah I also removed __init in the header file here because it doesn't do
> anything. I guess I should mention that in the commit text.

Indeed, you are right.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thread

[PATCH 00/34] Convert clk providers to clk_hw based APIs (part 1) Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
  [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
    Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration  and OF APIs Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-05 19:50 +0200
      Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration  and OF APIs Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-07 18:40 +0200
  [PATCH 20/34] clk: nomadik: Migrate to clk_hw based OF and registration APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
    Re: [PATCH 20/34] clk: nomadik: Migrate to clk_hw based OF and  registration APIs Linus Walleij <linus.walleij@linaro.org> - 2016-06-02 14:10 +0200
  [PATCH 01/34] clk: qcom: Migrate to clk_hw based registration and OF APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
  [PATCH 14/34] clk: cs2000: Migrate to clk_hw based OF and registration APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200

csiph-web