Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1414133
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs |
| Date | 2016-06-05 19:50 +0200 |
| Message-ID | <rGKlr-1mU-9@gated-at.bofh.it> (permalink) |
| References | <rFnAB-6CD-3@gated-at.bofh.it> <rFnKj-6FR-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
The main drawback of those patches is that they break the alignment
(checkpatch.pl --strict complains).
On 01/06/2016 at 16:15:06 -0700, Stephen Boyd wrote :
> diff --git a/drivers/clk/berlin/berlin2-avpll.h b/drivers/clk/berlin/berlin2-avpll.h
> index a37f5068d299..17e311153b42 100644
> --- a/drivers/clk/berlin/berlin2-avpll.h
> +++ b/drivers/clk/berlin/berlin2-avpll.h
> @@ -19,17 +19,13 @@
> #ifndef __BERLIN2_AVPLL_H
> #define __BERLIN2_AVPLL_H
>
> -struct clk;
> -
> #define BERLIN2_AVPLL_BIT_QUIRK BIT(0)
> #define BERLIN2_AVPLL_SCRAMBLE_QUIRK BIT(1)
>
> -struct clk * __init
> -berlin2_avpll_vco_register(void __iomem *base, const char *name,
> +int berlin2_avpll_vco_register(void __iomem *base, const char *name,
This is missing __init.
> const char *parent_name, u8 vco_flags, unsigned long flags);
>
> -struct clk * __init
> -berlin2_avpll_channel_register(void __iomem *base, const char *name,
> +int berlin2_avpll_channel_register(void __iomem *base, const char *name,
Ditto.
> u8 index, const char *parent_name, u8 ch_flags,
> unsigned long flags);
>
> diff --git a/drivers/clk/berlin/berlin2-pll.h b/drivers/clk/berlin/berlin2-pll.h
> index 8831ce27ac1e..796874facc4c 100644
> --- a/drivers/clk/berlin/berlin2-pll.h
> +++ b/drivers/clk/berlin/berlin2-pll.h
> @@ -19,8 +19,6 @@
> #ifndef __BERLIN2_PLL_H
> #define __BERLIN2_PLL_H
>
> -struct clk;
> -
> struct berlin2_pll_map {
> const u8 vcodiv[16];
> u8 mult;
> @@ -29,8 +27,7 @@ struct berlin2_pll_map {
> u8 divsel_shift;
> };
>
> -struct clk * __init
> -berlin2_pll_register(const struct berlin2_pll_map *map,
> +int berlin2_pll_register(const struct berlin2_pll_map *map,
Ditto.
> void __iomem *base, const char *name,
> const char *parent_name, unsigned long flags);
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/34] Convert clk providers to clk_hw based APIs (part 1) Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
[PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-05 19:50 +0200
Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-07 18:40 +0200
[PATCH 20/34] clk: nomadik: Migrate to clk_hw based OF and registration APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
Re: [PATCH 20/34] clk: nomadik: Migrate to clk_hw based OF and registration APIs Linus Walleij <linus.walleij@linaro.org> - 2016-06-02 14:10 +0200
[PATCH 01/34] clk: qcom: Migrate to clk_hw based registration and OF APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
[PATCH 14/34] clk: cs2000: Migrate to clk_hw based OF and registration APIs Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-02 01:30 +0200
csiph-web