Re: [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing
Date	2016-06-07 16:10 +0200
Message-ID	<rHpRD-3Ha-3@gated-at.bofh.it> (permalink)
References	<rHiGt-7uM-5@gated-at.bofh.it> <rHiQa-7y0-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/07/2016 02:30 AM, Jan Beulich wrote:
> Reads following writes with all address bits set to 1 should return all
> changeable address bits as one, not the BAR size (nor, as was the case
> for the upper half of 64-bit BARs, the high half of the region's end
> address). Presumably this didn't cause any problems so far because
> consumers use the value to calculate the size (usually via val & -val),
> and do nothing else with it.
>
> But also consider the exception here: Unimplemented BARs should always
> return all zeroes.
>
> And finally, the check for whether to return the sizing address on read
> for the ROM BAR should ignore all non-address bits, not just the ROM
> Enable one.


Should this go to stable trees as well?

-boris

Thread

[PATCH v2 0/2] xen-pciback: correct and clean up BAR handling "Jan Beulich" <JBeulich@suse.com> - 2016-06-07 08:30 +0200
  [PATCH v2 1/2] xen-pciback: return proper values during BAR  sizing "Jan Beulich" <JBeulich@suse.com> - 2016-06-07 08:40 +0200
    Re: [PATCH v2 1/2] xen-pciback: return proper values during BAR  sizing Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-07 16:10 +0200
      Re: [PATCH v2 1/2] xen-pciback: return proper values during  BAR sizing "Jan Beulich" <JBeulich@suse.com> - 2016-06-07 16:20 +0200
  [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() "Jan Beulich" <JBeulich@suse.com> - 2016-06-07 08:40 +0200
    Re: [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-07 16:10 +0200

csiph-web