RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

From	Hayes Wang <hayeswang@realtek.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date	2016-06-07 16:00 +0200
Message-ID	<rHpHY-3oH-19@gated-at.bofh.it> (permalink)
References	<rH6vF-7U4-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Mario Limonciello [mailto:mario_limonciello@dell.com]
[...]
> +		ret = hex2bin(buf, obj->string.pointer + 9, 6);
> +		if (ret < 0 || !is_valid_ether_addr(buf)) {
> +			netif_warn(tp, probe, tp->netdev, "Invalid MAC\n");
> +			goto amacout;
> +		}

If hex2bin() is success, the ret would be 0.
And you would return 0 when !is_valid_ether_addr(buf) occurs.
I don't think it is what you wants.

Best Regards,
Hayes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-06 19:30 +0200
  RE: [EXT] [PATCH v4] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 19:50 +0200
  RE: [EXT] [PATCH v4] r8152: Add support for setting pass through MAC  address on RTL8153-AD Konstantin Shkolnyy <Konstantin.Shkolnyy@silabs.com> - 2016-06-06 19:50 +0200
  Re: [PATCH v4] r8152: Add support for setting pass through MAC  address on RTL8153-AD Pali Rohár <pali.rohar@gmail.com> - 2016-06-07 10:00 +0200
  RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD Hayes Wang <hayeswang@realtek.com> - 2016-06-07 16:00 +0200

csiph-web