Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test

From	Yingjoe Chen <yingjoe.chen@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test
Date	2016-06-07 15:20 +0200
Message-ID	<rHp5g-3b5-17@gated-at.bofh.it> (permalink)
References	<rGca6-4Ez-9@gated-at.bofh.it> <rH5SV-7rk-11@gated-at.bofh.it> <rH8e6-z8-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

Thanks for the review.


On Mon, 2016-06-06 at 20:10 +0100, Andy Whitcroft wrote:
> On Mon, Jun 06, 2016 at 09:43:15AM -0700, Joe Perches wrote:
> > On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote:
> > > If a Kconfig config option doesn't specify 'default', the default
> > > will be n. Adding 'default n' is unnecessary.
> > > Add a test to warn about this.
> > 
> > Is it obvious that a Kconfig has "default n" ?
> > This seems to work, but is this useful?


While sending patch for upstream, I saw maintainers request it to be
removed. So I think it might worth adding check to it.
Some examples from google:

http://lists.infradead.org/pipermail/linux-arm-kernel/2012-September/120733.html
https://lkml.org/lkml/2013/3/16/153
https://lkml.org/lkml/2016/5/23/657


> 
> > > +		if ($realfile =~ /Kconfig/ &&
> > > +		    $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) {
> 
> I wonder particually when the submitter has supplied a comment, presumably
> to tell us why it defaults to 'n'.  I feel more accepting of rejecting
> uncommented ones than those with.


How about change this to /^\+\s*default\s*n$/i ?

Joe.C

Thread

[PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-06-04 07:20 +0200
  [PATCH v3 2/2] checkpatch: testing more config for Kconfig help text Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-06-04 07:20 +0200
  Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Joe Perches <joe@perches.com> - 2016-06-06 18:50 +0200
    Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Andy Whitcroft <apw@canonical.com> - 2016-06-06 21:20 +0200
      Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-06-07 15:20 +0200
        Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Paul Bolle <pebolle@tiscali.nl> - 2016-06-08 21:50 +0200

csiph-web