Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415284

Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test

Show all headers | View raw

On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote:
> If a Kconfig config option doesn't specify 'default', the default
> will be n. Adding 'default n' is unnecessary.
> Add a test to warn about this.

Is it obvious that a Kconfig has "default n" ?
This seems to work, but is this useful?

> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> ---
> For this series, rebase to v4.7-rc1 and dropped 'relax Kconfig help text
> line number threshold' patch.
> 
> Let me know what you think. Thanks.
> 
> 
> Change in v3:
> - Rebase to v4.7-rc1
> 
> Change in v2:
> - Change according to Joe Perches' suggesti
> 
>  scripts/checkpatch.pl | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6750595..f5ce804 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2683,6 +2683,13 @@ sub process {
>  			     "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
>  		}
>  
> +# discourage the use of default n
> +		if ($realfile =~ /Kconfig/ &&
> +		    $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) {
> +			WARN("CONFIG_DEFAULT_N",
> +			     "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr);
> +		}
> +
>  		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
>  		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
>  			my $flag = $1;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-06-04 07:20 +0200
  [PATCH v3 2/2] checkpatch: testing more config for Kconfig help text Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-06-04 07:20 +0200
  Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Joe Perches <joe@perches.com> - 2016-06-06 18:50 +0200
    Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Andy Whitcroft <apw@canonical.com> - 2016-06-06 21:20 +0200
      Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-06-07 15:20 +0200
        Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Paul Bolle <pebolle@tiscali.nl> - 2016-06-08 21:50 +0200

csiph-web