Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416120

RE: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support

Show all headers | View raw

Hi Florian,

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> Sent: 07 June 2016 00:12
> To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S.
> Miller
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; bcm-
> kernel-feedback-list@broadcom.com; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; Jon Mason
> Subject: Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support
>
> On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> > Add PCI Phy support for Broadcom Northstar2 SoCs.  This driver uses
> > the interface from the iproc mdio mux driver to enable the devices
> > respective phys.
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Jon Mason <jonmason@broadcom.com>
> > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
> > ---
> >  drivers/phy/Kconfig            |   8 +++
> >  drivers/phy/Makefile           |   2 +-
> >  drivers/phy/phy-bcm-ns2-pcie.c | 115
> > +++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 124 insertions(+), 1 deletion(-)  create mode 100644
> > drivers/phy/phy-bcm-ns2-pcie.c
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index
> > b869b98..01fb93b 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -434,4 +434,12 @@ config PHY_CYGNUS_PCIE
> >
> >  source "drivers/phy/tegra/Kconfig"
> >
> > +config PHY_NS2_PCIE
> > +	tristate "Broadcom Northstar2 PCIe PHY driver"
> > +	depends on OF && MDIO_BUS_MUX_BCM_IPROC
> > +	select GENERIC_PHY
> > +	default ARCH_BCM_IPROC
>
> Are not you missing a dependency on PHYLIB too to provide
> mdio_module_register() etc. (at least make it build)?
>

This depends on MDIO_BUS_MUX_BCM_IPROC which itself depends on PHYLIB. Hence
I don't think We need to take care of this here.

> --
> Florian

Regards,
Pramod

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/7] Add MDIO bus multiplexer support for iProc SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
  [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:40 +0200
      RE: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-10 06:30 +0200
  [PATCH v4 6/7] binding: PHY: Binding doc for NS2 PCIe PHYs. Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
  [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:50 +0200
      RE: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-07 14:30 +0200
  [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Andrew Lunn <andrew@lunn.ch> - 2016-06-06 16:20 +0200
    Re: [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:50 +0200
  [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom  MDIO bus multiplexer Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:40 +0200
      RE: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom  MDIO bus multiplexer Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-07 14:00 +0200
        Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for  Broadcom MDIO bus multiplexer Rob Herring <robh@kernel.org> - 2016-06-08 21:50 +0200
    Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for  Broadcom MDIO bus multiplexer Rob Herring <robh@kernel.org> - 2016-06-08 21:50 +0200

csiph-web