Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416093

RE: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer

Show all headers | View raw

Hi Florian,

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> Sent: 07 June 2016 00:06
> To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S.
> Miller
> Cc: devicetree@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; bcm-kernel-feedback-list@broadcom.com; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for
> Broadcom MDIO bus multiplexer
>
> On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> > Add DT binding doc for Broadcom MDIO bus multiplexer driver.
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
>
> > +for example:
> > +		mdio_mux_iproc: mdio-mux@6602023c {
>
> I think Rob wanted you to drop the underscores here in favor of dashes,
> there
> are more below, not critical imho.
>

I'd changed node name in favor of dashes. I don't think Label could be
written with hyphens,"-".  "-" in label provides DT parsing error.


> > +			compatible = "brcm,mdio-mux-iproc";
> > +			reg = <0x6602023c 0x14>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			mdio@0 {
> > +				reg = <0x0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pci_phy0: pci-phy@0 {
>
>
> --
> Florian

Regards,
Pramod

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/7] Add MDIO bus multiplexer support for iProc SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
  [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:40 +0200
      RE: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-10 06:30 +0200
  [PATCH v4 6/7] binding: PHY: Binding doc for NS2 PCIe PHYs. Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
  [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:50 +0200
      RE: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-07 14:30 +0200
  [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Andrew Lunn <andrew@lunn.ch> - 2016-06-06 16:20 +0200
    Re: [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:50 +0200
  [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-06 14:50 +0200
    Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom  MDIO bus multiplexer Florian Fainelli <f.fainelli@gmail.com> - 2016-06-06 20:40 +0200
      RE: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom  MDIO bus multiplexer Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-07 14:00 +0200
        Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for  Broadcom MDIO bus multiplexer Rob Herring <robh@kernel.org> - 2016-06-08 21:50 +0200
    Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for  Broadcom MDIO bus multiplexer Rob Herring <robh@kernel.org> - 2016-06-08 21:50 +0200

csiph-web