Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416131

Re: [PATCH v2] IB/core: remove dead code

Show all headers | View raw

On 07/06/16 00:15, Sudip Mukherjee wrote:
> prot_sg_cnt has been assigned with the value of ret which we have
> already checked to be non-zero so prot_sg_cnt can never be zero at this
> point of the code and hence the else part can never execute.
> And since we know prot_sg_cnt is non zero there is no use for the
> if condition also.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>   drivers/infiniband/core/rw.c | 24 ++++++++++--------------
>   1 file changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c
> index 1eb9b12..a829a14 100644
> --- a/drivers/infiniband/core/rw.c
> +++ b/drivers/infiniband/core/rw.c
> @@ -386,21 +386,17 @@ int rdma_rw_ctx_signature_init(struct rdma_rw_ctx *ctx, struct ib_qp *qp,
>   	count += ret;
>   	prev_wr = &ctx->sig->data.reg_wr.wr;
>
> -	if (prot_sg_cnt) {
> -		ret = rdma_rw_init_one_mr(qp, port_num, &ctx->sig->prot,
> -				prot_sg, prot_sg_cnt, 0);
> -		if (ret < 0)
> -			goto out_destroy_data_mr;
> -		count += ret;
> +	ret = rdma_rw_init_one_mr(qp, port_num, &ctx->sig->prot,
> +				  prot_sg, prot_sg_cnt, 0);
> +	if (ret < 0)
> +		goto out_destroy_data_mr;
> +	count += ret;
>
> -		if (ctx->sig->prot.inv_wr.next)
> -			prev_wr->next = &ctx->sig->prot.inv_wr;
> -		else
> -			prev_wr->next = &ctx->sig->prot.reg_wr.wr;
> -		prev_wr = &ctx->sig->prot.reg_wr.wr;
> -	} else {
> -		ctx->sig->prot.mr = NULL;
> -	}
> +	if (ctx->sig->prot.inv_wr.next)
> +		prev_wr->next = &ctx->sig->prot.inv_wr;
> +	else
> +		prev_wr->next = &ctx->sig->prot.reg_wr.wr;
> +	prev_wr = &ctx->sig->prot.reg_wr.wr;
>
>   	ctx->sig->sig_mr = ib_mr_pool_get(qp, &qp->sig_mrs);
>   	if (!ctx->sig->sig_mr) {
>

Actually it looks like the data-integrity insert/strip operation
(where protection sg list does not exist) is broken.

It looks that the protection scatterlist should be done only if
prot_sg_count was provided...

I don't have access to mlx5 devices at the moment (still waiting
to get some...)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] IB/core: remove dead code Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-06 23:20 +0200
  Re: [PATCH v2] IB/core: remove dead code Leon Romanovsky <leon@kernel.org> - 2016-06-07 09:40 +0200
  Re: [PATCH v2] IB/core: remove dead code Sagi Grimberg <sagi@lightbits.io> - 2016-06-07 14:50 +0200
    Re: [PATCH v2] IB/core: remove dead code Christoph Hellwig <hch@infradead.org> - 2016-06-07 14:50 +0200
      Re: [PATCH v2] IB/core: remove dead code Sagi Grimberg <sagi@lightbits.io> - 2016-06-07 15:20 +0200

csiph-web