Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1416138

Re: [PATCH v2] IB/core: remove dead code

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] IB/core: remove dead code
Date 2016-06-07 14:50 +0200
Message-ID <rHoCe-2KD-25@gated-at.bofh.it> (permalink)
References <rHa6d-1IG-7@gated-at.bofh.it> <rHoCe-2KD-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jun 07, 2016 at 03:41:04PM +0300, Sagi Grimberg wrote:
> Actually it looks like the data-integrity insert/strip operation
> (where protection sg list does not exist) is broken.
> 
> It looks that the protection scatterlist should be done only if
> prot_sg_count was provided...
> 
> I don't have access to mlx5 devices at the moment (still waiting
> to get some...)

I've reported the brokenness in the existing iSER code when I started
working on signature MR support in the generic API.  As no one helped
managed to figure out the issue or how it should operate I clone the
existing semantics, even given I knew they are broken.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] IB/core: remove dead code Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-06 23:20 +0200
  Re: [PATCH v2] IB/core: remove dead code Leon Romanovsky <leon@kernel.org> - 2016-06-07 09:40 +0200
  Re: [PATCH v2] IB/core: remove dead code Sagi Grimberg <sagi@lightbits.io> - 2016-06-07 14:50 +0200
    Re: [PATCH v2] IB/core: remove dead code Christoph Hellwig <hch@infradead.org> - 2016-06-07 14:50 +0200
      Re: [PATCH v2] IB/core: remove dead code Sagi Grimberg <sagi@lightbits.io> - 2016-06-07 15:20 +0200

csiph-web