Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415976

[ldv-project] [net] libertas: potential race condition

Show all headers | View raw

Hi!

There is a potential race condition in 
drivers/net/wireless/libertas/libertas.ko.
In the function lbs_hard_start_xmit(..), line 159, a socket buffer is 
written to priv->current_skb with a spin_lock protection.
In the function lbs_mac_event_disconnected(..), lines 50-51, the field 
current_skb is cleaned. There is no protection used. The corresponding 
handlers are activated at the same time in lbs_start_card(..) and then 
may be executed simultaneously. Note, there are two structures 
lbs_netdev_ops and mesh_netdev_ops, which have the target handler 
lbs_hard_start_xmit.
Is it a real race or I have missed something?

-- 
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@ispras.ru

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[ldv-project] [net] libertas: potential race condition Pavel Andrianov <andrianov@ispras.ru> - 2016-06-07 12:40 +0200
  Re: [ldv-project] [net] libertas: potential race condition Dan Williams <dcbw@redhat.com> - 2016-06-07 16:50 +0200
    Re: [ldv-project] [net] libertas: potential race condition Pavel Andrianov <andrianov@ispras.ru> - 2016-06-07 18:00 +0200
    Re: [ldv-project] [net] libertas: potential race condition James Cameron <quozl@laptop.org> - 2016-06-08 01:00 +0200

csiph-web