Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415916

Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

From Lee Jones <lee.jones@linaro.org>
Newsgroups linux.kernel
Subject Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines
Date 2016-06-07 11:30 +0200
Message-ID <rHluG-Te-11@gated-at.bofh.it> (permalink)
References <rH56x-6VJ-19@gated-at.bofh.it> <rHkRY-qE-9@gated-at.bofh.it> <rHll0-PT-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 07 Jun 2016, Lee Jones wrote:

> On Tue, 07 Jun 2016, Peter Griffin wrote:
> 
> > Hi,
> > 
> > On Mon, 06 Jun 2016, Lee Jones wrote:
> > 
> > > Phasing out generic reset line requests enables us to make some better
> > > decisions on when and how to (de)assert said lines.  If an 'exclusive'
> > > line is requested, we know a device *requires* a reset and that it's
> > > preferable to act upon a request right away.  However, if a 'shared'
> > > reset line is requested, we can reasonably assume sure that placing a
> > > device into reset isn't a hard requirement, but probably a measure to
> > > save power and is thus able to cope with not being asserted if another
> > > device is still in use.
> > > 
> > > In order allow gentle adoption and not to forcing all consumers to
> > > move to the API immediately, causing administration headache between
> > > subsystems, this patch adds some temporary stand-in shim-calls.  This
> > > will ease the burden at merge time and allow subsystems to migrate over
> > > to the new API in a more realistic time-frame.
> > 
> > Is the intention that this series will be taken into the next -rc?
> > 
> > As the introduction of shared resets in reset subsystem has caused regressions
> > on STi platforms.
> 
> Yes, which is why it has a Fixes: tag.

Ah wait.  I thought this was the shared-memory patch.

More haste, less speed and all that.

I guess it should really go into the -rcs, yes.  Since Hans' patch
actually breaks a lot of devices.  I'm pretty surprised a patch
capable of this much damage was actually accepted to be honest.  A
better approach would have been to issue a warning, but keep the
semantics the same for at least a couple of releases.  However, I
guess the damage has been done now, so let's do what we can do fix
it.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
  [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
    Re: [STLinux Kernel] [PATCH 6/7] phy: miphy28lp: Inform the reset  framework that our reset line may be shared Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:40 +0200
    Re: [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our  reset line may be shared Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-07 11:10 +0200
  [PATCH 2/7] reset: Ensure drivers are explicit when requesting reset lines Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
  [PATCH 7/7] usb: dwc3: st: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
    [PATCH 9/10] usb: host: ehci-st: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 19:20 +0200
      Re: [PATCH 9/10] usb: host: ehci-st: Inform the reset framework that  our reset line may be shared Alan Stern <stern@rowland.harvard.edu> - 2016-06-06 19:50 +0200
    [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 19:20 +0200
      [PATCH 10/10] usb: host: ohci-st: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 19:20 +0200
      Re: [STLinux Kernel] [PATCH 8/10] phy: phy-stih407-usb: Inform the  reset framework that our reset line may be shared Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:40 +0200
      Re: [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework  that our reset line may be shared Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-07 11:10 +0200
    Re: [STLinux Kernel] [PATCH 7/7] usb: dwc3: st: Inform the reset  framework that our reset line may be shared Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:50 +0200
  [PATCH 5/7] reset: TRIVIAL: Add line break at same place for similar APIs Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
  [PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:10 +0200
  [PATCH 3/7] reset: Supply *_shared variant calls when using of_* API Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:10 +0200
  [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:10 +0200
  Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly  request 'exclusive' or 'shared' lines Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:50 +0200
    Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly  request 'exclusive' or 'shared' lines Lee Jones <lee.jones@linaro.org> - 2016-06-07 11:20 +0200
      Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly  request 'exclusive' or 'shared' lines Lee Jones <lee.jones@linaro.org> - 2016-06-07 11:30 +0200

csiph-web