Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415250

[PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers

From Lee Jones <lee.jones@linaro.org>
Newsgroups linux.kernel
Subject [PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers
Date 2016-06-06 18:10 +0200
Message-ID <rH5gd-7ea-5@gated-at.bofh.it> (permalink)
References <rH56x-6VJ-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


We're about to split the current API into two, where consumers will
be forced to be explicit when requesting reset lines.  The choice
will be to either the call the *_exclusive or *_shared variant
depending on whether they can actually tolorate not being asserted
when that request is made.

The new API will look like this once reorded and complete:

  reset_control_get_exclusive()
  reset_control_get_shared()
  reset_control_get_optional_exclusive()
  reset_control_get_optional_shared()
  of_reset_control_get_exclusive()
  of_reset_control_get_shared()
  of_reset_control_get_exclusive_by_index()
  of_reset_control_get_shared_by_index()
  devm_reset_control_get_exclusive()
  devm_reset_control_get_shared()
  devm_reset_control_get_optional_exclusive()
  devm_reset_control_get_optional_shared()
  devm_reset_control_get_exclusive_by_index()
  devm_reset_control_get_shared_by_index()

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 include/linux/reset.h | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/include/linux/reset.h b/include/linux/reset.h
index ec0306ce..33eaf11 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -107,12 +107,6 @@ static inline struct reset_control *__must_check reset_control_get(
 	return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 0);
 }
 
-static inline struct reset_control *reset_control_get_optional(
-					struct device *dev, const char *id)
-{
-	return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 0);
-}
-
 /**
  * reset_control_get_shared - Lookup and obtain a shared reference to a
  *                            reset controller.
@@ -141,6 +135,12 @@ static inline struct reset_control *reset_control_get_shared(
 	return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 1);
 }
 
+static inline struct reset_control *reset_control_get_optional(
+					struct device *dev, const char *id)
+{
+	return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 0);
+}
+
 /**
  * of_reset_control_get - Lookup and obtain an exclusive reference to a
  *                        reset controller.
@@ -191,6 +191,21 @@ static inline struct reset_control *__must_check devm_reset_control_get(
 	return __devm_reset_control_get(dev, id, 0, 0);
 }
 
+/**
+ * devm_reset_control_get_shared - resource managed reset_control_get_shared()
+ * @dev: device to be reset by the controller
+ * @id: reset line name
+ *
+ * Managed reset_control_get_shared(). For reset controllers returned from
+ * this function, reset_control_put() is called automatically on driver detach.
+ * See reset_control_get_shared() for more information.
+ */
+static inline struct reset_control *devm_reset_control_get_shared(
+					struct device *dev, const char *id)
+{
+	return __devm_reset_control_get(dev, id, 0, 1);
+}
+
 static inline struct reset_control *devm_reset_control_get_optional(
 					struct device *dev, const char *id)
 {
@@ -213,21 +228,6 @@ static inline struct reset_control *devm_reset_control_get_by_index(
 }
 
 /**
- * devm_reset_control_get_shared - resource managed reset_control_get_shared()
- * @dev: device to be reset by the controller
- * @id: reset line name
- *
- * Managed reset_control_get_shared(). For reset controllers returned from
- * this function, reset_control_put() is called automatically on driver detach.
- * See reset_control_get_shared() for more information.
- */
-static inline struct reset_control *devm_reset_control_get_shared(
-					struct device *dev, const char *id)
-{
-	return __devm_reset_control_get(dev, id, 0, 1);
-}
-
-/**
  * devm_reset_control_get_shared_by_index - resource managed
  * reset_control_get_shared
  * @dev: device to be reset by the controller
-- 
2.8.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
  [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
    Re: [STLinux Kernel] [PATCH 6/7] phy: miphy28lp: Inform the reset  framework that our reset line may be shared Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:40 +0200
    Re: [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our  reset line may be shared Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-07 11:10 +0200
  [PATCH 2/7] reset: Ensure drivers are explicit when requesting reset lines Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
  [PATCH 7/7] usb: dwc3: st: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
    [PATCH 9/10] usb: host: ehci-st: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 19:20 +0200
      Re: [PATCH 9/10] usb: host: ehci-st: Inform the reset framework that  our reset line may be shared Alan Stern <stern@rowland.harvard.edu> - 2016-06-06 19:50 +0200
    [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 19:20 +0200
      [PATCH 10/10] usb: host: ohci-st: Inform the reset framework that our reset line may be shared Lee Jones <lee.jones@linaro.org> - 2016-06-06 19:20 +0200
      Re: [STLinux Kernel] [PATCH 8/10] phy: phy-stih407-usb: Inform the  reset framework that our reset line may be shared Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:40 +0200
      Re: [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework  that our reset line may be shared Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-07 11:10 +0200
    Re: [STLinux Kernel] [PATCH 7/7] usb: dwc3: st: Inform the reset  framework that our reset line may be shared Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:50 +0200
  [PATCH 5/7] reset: TRIVIAL: Add line break at same place for similar APIs Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:00 +0200
  [PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:10 +0200
  [PATCH 3/7] reset: Supply *_shared variant calls when using of_* API Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:10 +0200
  [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs Lee Jones <lee.jones@linaro.org> - 2016-06-06 18:10 +0200
  Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly  request 'exclusive' or 'shared' lines Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 10:50 +0200
    Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly  request 'exclusive' or 'shared' lines Lee Jones <lee.jones@linaro.org> - 2016-06-07 11:20 +0200
      Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly  request 'exclusive' or 'shared' lines Lee Jones <lee.jones@linaro.org> - 2016-06-07 11:30 +0200

csiph-web