Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1415748
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm |
| Date | 2016-06-07 08:40 +0200 |
| Message-ID | <rHiQa-7y0-27@gated-at.bofh.it> (permalink) |
| References | <rFTqN-1hO-3@gated-at.bofh.it> <rFTqO-1hO-15@gated-at.bofh.it> <rHbbY-2wa-17@gated-at.bofh.it> <rHd46-3HM-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue 07-06-16 01:20:08, Oleg Nesterov wrote: > On 06/06, David Rientjes wrote: > > > > > There is a potential race where we kill the oom disabled task which is > > > highly unlikely but possible. It would happen if __set_oom_adj raced > > > with select_bad_process and then it is OK to consider the old value or > > > with fork when it should be acceptable as well. > > > Let's add a little note to the log so that people would tell us that > > > this really happens in the real life and it matters. > > > > > > > We cannot kill oom disabled processes at all, little race or otherwise. > > But this change doesn't really make it worse? Exactly, the race was always there. We could mitigate it to some degree by (ab)using oom_lock in __set_oom_adj. But I guess this is just an overkill. -- Michal Hocko SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-03 11:20 +0200
Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm David Rientjes <rientjes@google.com> - 2016-06-07 00:30 +0200
Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Oleg Nesterov <oleg@redhat.com> - 2016-06-07 02:30 +0200
Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-07 08:40 +0200
Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm David Rientjes <rientjes@google.com> - 2016-06-08 00:20 +0200
Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-08 08:30 +0200
Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm David Rientjes <rientjes@google.com> - 2016-06-09 01:00 +0200
Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-09 08:50 +0200
csiph-web