Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415599

Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm

From Oleg Nesterov <oleg@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm
Date 2016-06-07 02:30 +0200
Message-ID <rHd46-3HM-13@gated-at.bofh.it> (permalink)
References <rFTqN-1hO-3@gated-at.bofh.it> <rFTqO-1hO-15@gated-at.bofh.it> <rHbbY-2wa-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/06, David Rientjes wrote:
>
> > There is a potential race where we kill the oom disabled task which is
> > highly unlikely but possible. It would happen if __set_oom_adj raced
> > with select_bad_process and then it is OK to consider the old value or
> > with fork when it should be acceptable as well.
> > Let's add a little note to the log so that people would tell us that
> > this really happens in the real life and it matters.
> >
>
> We cannot kill oom disabled processes at all, little race or otherwise.

But this change doesn't really make it worse?

Oleg.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-03 11:20 +0200
  Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm David Rientjes <rientjes@google.com> - 2016-06-07 00:30 +0200
    Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Oleg Nesterov <oleg@redhat.com> - 2016-06-07 02:30 +0200
      Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-07 08:40 +0200
      Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm David Rientjes <rientjes@google.com> - 2016-06-08 00:20 +0200
        Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-08 08:30 +0200
          Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm David Rientjes <rientjes@google.com> - 2016-06-09 01:00 +0200
            Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko <mhocko@kernel.org> - 2016-06-09 08:50 +0200

csiph-web