Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415745

Re: block: correctly fallback for zeroout

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: block: correctly fallback for zeroout
Date 2016-06-07 08:40 +0200
Message-ID <rHiQa-7y0-17@gated-at.bofh.it> (permalink)
References <rD7Tk-1g2-21@gated-at.bofh.it> <rE2HT-2Ek-1@gated-at.bofh.it> <rFNEJ-6dz-3@gated-at.bofh.it> <rFOr7-6ts-9@gated-at.bofh.it> <rHf5T-56W-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 06, 2016 at 10:32:38PM -0400, Martin K. Petersen wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
> 
> Mike> But hch was originally in favor of _always_ dropping EOPNOTSUPP on
> Mike> the floor (that is what his commit 38f25255330 did).  Then he said
> Mike> he disagrees with these interfaces playing games with masking
> Mike> EOPNOTSUPP -- to which you seemingly really don't agree.  Unless
> Mike> I'm completely misreading you.
> 
> Userland apps rely on EOPNOTSUPP, we can't break that.

Rely on what exactly?  Current we return EOPNOTSUPP if the device
doesn't claim to support discards, but it returns 0 if the device first
claims to support it but then fails the I/O.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-03 05:10 +0200
  Re: block: correctly fallback for zeroout Mike Snitzer <snitzer@redhat.com> - 2016-06-03 06:00 +0200
    Re: block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-07 04:40 +0200
      Re: block: correctly fallback for zeroout Christoph Hellwig <hch@infradead.org> - 2016-06-07 08:40 +0200
        Re: block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-10 04:10 +0200

csiph-web