Re: block: correctly fallback for zeroout

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: block: correctly fallback for zeroout
Date	2016-06-07 04:40 +0200
Message-ID	<rHf5T-56W-7@gated-at.bofh.it> (permalink)
References	<rD7Tk-1g2-21@gated-at.bofh.it> <rE2HT-2Ek-1@gated-at.bofh.it> <rFNEJ-6dz-3@gated-at.bofh.it> <rFOr7-6ts-9@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

>>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:

Mike> But hch was originally in favor of _always_ dropping EOPNOTSUPP on
Mike> the floor (that is what his commit 38f25255330 did).  Then he said
Mike> he disagrees with these interfaces playing games with masking
Mike> EOPNOTSUPP -- to which you seemingly really don't agree.  Unless
Mike> I'm completely misreading you.

Userland apps rely on EOPNOTSUPP, we can't break that.

What I don't like this is "soft" error special casing of EOPNOTSUPP in
the actual implementation of discard, write same, etc. These functions
should return either success or failure. And the ioctl wrapper should
then decide whether to return EOPNOTSUPP, EIO or EPONIES.

I.e. separate the policy from the implementation. This would also solve
some of the grievances for the target folks.

-- 
Martin K. Petersen	Oracle Linux Engineering

Thread

Re: [PATCH] block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-03 05:10 +0200
  Re: block: correctly fallback for zeroout Mike Snitzer <snitzer@redhat.com> - 2016-06-03 06:00 +0200
    Re: block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-07 04:40 +0200
      Re: block: correctly fallback for zeroout Christoph Hellwig <hch@infradead.org> - 2016-06-07 08:40 +0200
        Re: block: correctly fallback for zeroout "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-10 04:10 +0200

csiph-web