Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove create_workqueue

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove create_workqueue
Date	2016-06-07 03:20 +0200
Message-ID	<rHdQt-4hl-7@gated-at.bofh.it> (permalink)
References	<rGlGq-2OD-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date: Sat, 4 Jun 2016 20:54:00 +0530

> alloc_workqueue replaces deprecated create_workqueue().
> 
> A dedicated workqueue has been used since the workitem viz
> (&db_wq->wk.work which maps to check_db_timeout) is involved
> in normal device operation. WQ_MEM_RECLAIM has been set to guarantee
> forward progress under memory pressure, which is a requirement here.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary.
> 
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: ethernet: cavium: liquidio: request_manager: Remove  create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-04 17:30 +0200
  Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove  create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-05 12:30 +0200
  Re: [PATCH] net: ethernet: cavium: liquidio: request_manager:  Remove create_workqueue David Miller <davem@davemloft.net> - 2016-06-07 03:20 +0200

csiph-web